Check for HTTPS in $_SERVER fails [#1942126]

On line 460 of sharethis.module it checks for $_SERVER['HTTPS'] == 'on' to determine whether to use the secure Javascript include or not. The site I'm working on has ON as uppercase however, so this check fails.

I suggest a simple strtolower() before the check for it to work in both eventualities.
if (isset($_SERVER['HTTPS']) && strtolower($_SERVER['HTTPS']) == 'on') {

Comment	File	Size	Author
#3	sharethis-check_for_HTTPS_fails-1942126-3.patch	590 bytes	Gaofengzzz
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jlockhart

English

PNW Washington

CreditAttribution: jlockhart commented 19 April 2013 at 17:17

Worked for me, site reports all secure now.

Comment #2

AL the X CreditAttribution: AL the X commented 19 June 2013 at 17:07

Better would be to include the Javascript _without_ the protocol, e.g. <script src="//example.com/path/to/library.js"></script>, which bypasses the problem of checking (or normalizing) the $_SERVER["HTTPS"] value.