This is a sub-issue of #1938580: [META] Make active config save format match the default yml file (order and quotes). Check meta issue for Steps to reproduce and Coding standards

Files need to be fixed
forum.settings.yml

Files fixed already

Remaining tasks

CommentFileSizeAuthor
#9 1942130-filter-config-format-9.patch355 bytesxtfer
#1 1942130-filter-config-format-1.patch357 bytessandipmkhairnar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sandipmkhairnar’s picture

sandipmkhairnar CreditAttribution: sandipmkhairnar commented
Status: Active » Needs review
FileSize
1942130-filter-config-format-1.patch357 bytes

Mapped forum module to active config file.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Component: filter.module » forum.module

Not sure whether it is changed in default or setting by default. Will need more review.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Issue tags: -Configuration system, -Config novice

#1: 1942130-filter-config-format-1.patch queued for re-testing.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented

#1: 1942130-filter-config-format-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1942130-filter-config-format-1.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Status: Needs work » Needs review
Issue tags: +Configuration system, +Config novice

#1: 1942130-filter-config-format-1.patch queued for re-testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/forum/config/forum.settings.ymlundefined
@@ -8,4 +8,4 @@ topics:
+vocabulary: 'forums'

really, really minor nit but there should not be single quotes around 'forums' to match the active config format after enabling the forum module.

xtfer’s picture

xtfer CreditAttribution: xtfer commented
Status: Needs work » Needs review
FileSize
1942130-filter-config-format-9.patch355 bytes

Updated patch based on #8.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community

thanks

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 67a8014 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.