Make the "Free Shipping on Orders Over 99" block configurable. [#1942310]

Comment	File	Size	Author
#3	commerce_kickstart_block_module.patch	2.68 KB	medden
	commerce_kickstart_block.patch	2.57 KB	medden

Comment #1

joshmiller

he/him

English

Indianapolis, Indiana, USA

CreditAttribution: joshmiller commented 14 March 2013 at 15:06

Status:

Active

» Needs work

Haven't tested, but maybe you could make one change...

+++ b/public/profiles/commerce_kickstart/modules/commerce_kickstart/commerce_kickstart_block/commerce_kickstart_block.moduleundefined
@@ -51,7 +81,11 @@ function commerce_kickstart_block_block_view($delta = '') {
+        $amount = '9999';

I would recommend changing this to 2500 to keep the original design.

Log in or register to post comments

Comment #2

medden CreditAttribution: medden commented 15 March 2013 at 08:24

In the Kickstart I downloaded, the discount amount was listed as $0.99
But in the Shipping Condition Rules, there was an option for free delivery on orders over $99.99
I changed them both to $25.00 coincidently, as that was the required amount for my store.

I agree the patch should keep the amount the same as before, but perhaps we can open another issue to match the discount block amount, with the discount rule.

Log in or register to post comments

Comment #3

medden CreditAttribution: medden commented 15 March 2013 at 10:34

File	Size
commerce_kickstart_block_module.patch	2.68 KB

Here is an updated patch, made from a clean install of commerce kickstart.
It does change the shipping discount to $99.99, which now matches the free shipping rule that gets enabled in kickstart.
Having one set at 0.99 and the other at 99.99 seems confusing right.

Log in or register to post comments

Comment #4

makokis CreditAttribution: makokis commented 4 August 2013 at 18:18

I aplied this two patchs but,
how can I hide decimals to get 300€ and not 300,00€ ?

thanks

Log in or register to post comments

Comment #5

jsacksick CreditAttribution: jsacksick commented 8 August 2013 at 12:04

@makokis :

how can I hide decimals to get 300€ and not 300,00€ ?

You currently can because it uses the commerce_currency_format() function, that is a sample block, if you need something really different you should define your own, otherwise the module could expose a setting to say "I want this amount to be passed to the commerce_currency_format function.

Log in or register to post comments

Comment #6

makokis CreditAttribution: makokis commented 23 August 2013 at 23:27

thanks for your help but... I don't understand how and where can I change that. Maybe if you can post an screenshot.

thanks in advance

Log in or register to post comments

Comment #7

bigmonmulgrew CreditAttribution: bigmonmulgrew commented 8 November 2013 at 11:01

Great work. Thanks a lot for this.

Log in or register to post comments

Comment #8

lsolesen CreditAttribution: lsolesen commented 30 March 2014 at 13:32

Issue summary:	View changes
Status:	Needs work	» Needs review

Seems that we need to review the latest patch?

Log in or register to post comments

Comment #9

lsolesen CreditAttribution: lsolesen commented 21 April 2014 at 21:39

The shipping block on the frontpage should match the rule, so I created this pull request https://github.com/commerceguys/commerce_kickstart/pull/38

I agree that it could easily be configurable. However, it should probably work together with the rule then, because otherwise people might get thrown off when changing the block does not change the rule?

Log in or register to post comments

Comment #10

mglaman

English

WI, USA

CreditAttribution: mglaman at Centarro commented 16 July 2015 at 20:45

Status:	Needs review	» Needs work
Related issues:		+#1821798: Discounts should be able to activate one or more blocks

Rather than come up with a variable for the block, it seems the proper fix would be #1821798: Discounts should be able to activate one or more blocks. Also, isn't this block and the shipping discount part of the demo store?