Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Tags vocabulary could be created by importing config file
Comment | File | Size | Author |
---|---|---|---|
#2 | tags-standard-profile.png | 21.46 KB | andypost |
tags-standard-profile.patch | 3.86 KB | andypost | |
Comments
Comment #1
andypostPatch also removes useless "help-property" usage.
Interesting case for D8MI
Suppose language of the tags should be English by default because of name and description.
But would we loose the ability to translate them in install time...
Suppose language of the tags should be English language by default because of name and description
Comment #2
andypostManual testing shows that Vocabulary stays untranslated
shipped with English
Comment #3
Gábor HojtsyYes, you can change the vocabulary name and description as well as the language of the vocabulary after install (on the screen demonstrated). Then there is #1905152: Integrate config schema with locale, so shipped configuration is translated and the various schema issues being written (http://www.drupal8multilingual.org/issues/schema) to put an understanding of the structure of config files for use within the locale system to identify translatable strings and make it possible to save translations for them based on software-pre-translation from localize.drupal.org.
As for the patch: For translation, it is not really different whether the .yml file is created in the installation process is already shipped with core. Also, including langcode: en for shipped config files is indeed best practice.
Comment #4
andypost@Gabor so what you can recommend about the patch about it's time to be commited? I think most of things from (profile).install should be moved to their config files and Tags name is a nice example to start with
Comment #5
Gábor HojtsyIt should end up being translatable either way. The config translation system is still being built as demonstrated, but Drupal 8 will need that to work to avoid major regressions anyway. So it should be fine as config files, yup. I agree it is cleaner to include config "exports" in the profile instead of creating the config programatically unless something really depends on user input or other conditions.
Comment #6
tim.plunkettAs I see it, this is RTBC
Comment #7
xjmtags-standard-profile.patch queued for re-testing.
Comment #8
xjm+1, this is an excellent cleanup.
Comment #9
xjmComment #10
webchickLovely!
Committed and pushed to 8.x. Thanks!