Problem/Motivation

Drupal coding standards for indentation require line endings to be LF and not CRLF. The templates/panels-add-content-link.tpl.php has CRLF line endings.

Please note although I found Issue 933702 which is almost identical to this one, but as it was asking to remove line feeds instead of correcting line ending I was not too sure if that bug was the best place to put this. If I am wrong I am sorry for this.

Proposed resolution

I have attached in #1 a patch which simply reverts the line endings to LF instead of CRLF

CommentFileSizeAuthor
#1 panels-coding-standards-task-1943970-1.patch737 bytescferthorney
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cferthorney’s picture

cferthorney
he/them
Primary language English
Location Huntingdon, UK
CreditAttribution: cferthorney commented
Status: Active » Needs review
FileSize
panels-coding-standards-task-1943970-1.patch737 bytes

Please find attached patch for the above reported task

mariacha1’s picture

mariacha1 CreditAttribution: mariacha1 commented
Status: Needs review » Reviewed & tested by the community

I applied this patch with git and verified there were no longer CRLF line endings in the file with VIM. Looks good to me.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Fixed. Thanks!

http://drupalcode.org/project/panels.git/commit/be1deaf

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit be1deaf on 7.x-3.x, 8.x-3.x authored by cferthorney, committed by japerry: 
    Issue #1943970 by cferthorney: standards cleanup, use CRLF instead of LF...