Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Same as issue http://drupal.org/node/1940474, but there is no patch for Drupal 6 users. I tried the patches and suggestions mentioned there to no avail.
Comment | File | Size | Author |
---|---|---|---|
#29 | location-google-geocode-update-1944120.patch | 3.03 KB | johnlutz |
#17 | 1944120-google-geocode-update.patch | 3.03 KB | johnlutz |
#8 | location6-3-dev.patch | 2.77 KB | dunx |
#7 | location6-3-2.patch | 2.77 KB | dunx |
Comments
Comment #1
podarokbetter title and Due to #1940474: Google geocoding returned status code: 610 it is a task for backporting
Comment #2
littleneo CreditAttribution: littleneo commentedtried to adapt the 7x #27 patch by hand to google.inc with no success. (location 6x-3xdev 17march)
also uh it seems you now need to enable the google map geolocation API feature at code.google.com right ?
I updated the gmap and location modules from 6x-1 to dev as I noticed geolocation was not working anymore this afternoon with the APIv2. until now I never enabled this google map geolocation API feature. Does geolocation works for you using APIv2 (should I downgrade meanwhile ?)
also this ?
https://developers.google.com/maps/documentation/business/geolocation/#u...
Comment #3
littleneo CreditAttribution: littleneo commentedok #27 looks like an attempt to patch a patch.. #2 + $status_code mod. is fine for 6x with the described tweak
geocoding now ok (in france at least (no province field use)).
just removed the gl argument from the query in v7 #2 patch as it does not seem to be an api argument anymore (see)
below a geocoding-working-so-far-with-apiv3 google.inc file for 6x-3xdev from today to review :
( also no need to turn on google map geolocation API feature.. no key anymore in args ? )
Comment #4
littleneo CreditAttribution: littleneo commentedComment #5
podarokplease, do upload a patch against latest 6.x-3.x-dev. not a code via comment post.
Comment #6
littleneo CreditAttribution: littleneo commentedsorry I would have if I was used to. got no time and doesn't know GNU patch very well. just replace entirely the file.
Comment #7
dunx CreditAttribution: dunx commentedHere's a patch for 3.2 for those that need it now.
Comment #8
dunx CreditAttribution: dunx commentedI think this patch will do for -dev, but I can't test it.
Comment #9
dunx CreditAttribution: dunx commentedJust to clarify; both the above patches are for location/geocoding/google.inc
Comment #10
rougekris CreditAttribution: rougekris commentedI patched my Location module (6.x-3.x) with the instructions in the corresponding 7.x issue. I had to do it manually of course, but it works perfectly.
Something I need to mention though is that when you're fixing the information in the content/profiles, you need to enter a different postal code or otherwise Location won't change the geocoding. I was going in to content and saving it, but that's not enough.
Comment #11
podarokbot
Comment #13
podarokpatch is in wrong format
look at http://drupal.org/patch
Comment #14
dunx CreditAttribution: dunx commentedAh, yes should have used -p1 format. Sorry, but deleted all my working files now, so can't quickly reproduce.
In the meantime, I guess all D6 location geocoding has stopped working.
Comment #15
manoloka CreditAttribution: manoloka commentedPatch of post #2 and comment #9 from http://drupal.org/node/1940474 solved the issue for me.
I'm and I'm on D6 (even though the post is for D7)
Comment #16
podarok#15 can You upload patch against latest dev
Comment #17
johnlutzWent off of dunx's changes and they worked, so just patched dev correctly (I hope)
Comment #18
johnlutzComment #19
podaroktabstops should be spaces errors
trailing whitespaces errors
http://drupal.org/coding-standards#indenting
Comment #20
webservant316 CreditAttribution: webservant316 commentedThe patch at #17 works for me. I needed to re-save each node to get the map to reset by changing something on the location such as the zipcode and then changing it back. Anyone know of a better way to do that???
Comment #21
rougekris CreditAttribution: rougekris commented#20:
I already mentioned this in #10. It's vital though, and should probably be in the patch notes somewhere.
Comment #22
webservant316 CreditAttribution: webservant316 commented#20, yep. But does anyone know of a better way to do that than re-saving each node? I took me an hour to go through all my nodes. Seems like there ought to be an automatic means to do that.
Comment #23
rougekris CreditAttribution: rougekris commentedI understand why the functionality is in place, but it was a pain on this occasion. Thankfully, it was an issue on a site that isn't teeming with activity, so I only had five or six users to re-edit.
My understanding of the module, from a code standpoint (having gone through the same issue you did), is that manually re-geocoding each node/user/entity is the only way to go. It's useful for 99.9% of the time except for now.
Comment #24
podarokdue to #19 and especially #20 this needs work
Comment #25
ellastelter CreditAttribution: ellastelter commentedYay! #17 worked for me. Thanks everyone!
Comment #26
webservant316 CreditAttribution: webservant316 commentedThe cumbersome node re-saving related to #20 isn't a deficiency in the patch, but only that the location module doesn't have a means to force the re-geocoding of all or select locations. It is further complicated because the location module assumes that unless the text of the address changes, there is no need to recalculate. This seems like a logical thing to do, however, if you want to force a recalculation you can only do that by changing the address, saving, then changing it back again, and re-saving.
Perhaps a checkbox could be added that indicates to re-geocode on the save of a node or user regardless. Perhaps also add an administrative function to re-geocode all locations. I will create a feature request issue for these ideas.
http://drupal.org/node/1948640
http://drupal.org/node/1948642
Comment #27
podarokits not fixed
Comment #28
Anonymous (not verified) CreditAttribution: Anonymous commentedPatch in #17 worked for me. Ensure you have the Geocoding API enabled in your Google API settings.
Comment #29
johnlutzUpdated patch per comments in #19.
Comment #30
podarok#29 commited pushed to 6.x-3.x
thanks!!!
Comment #31
podaroktagged new beta release
http://drupal.org/node/1949934