Add the pagination component. See http://groups.drupal.org/node/283223#Pagination

CommentFileSizeAuthor
#5 pagination-5.patch7.43 KBry5n
#5 pagination-4-5.interdiff.txt1.34 KBry5n
#4 pagination-p4.patch11.21 KBoresh
#3 pagination-p3.patch10.85 KBry5n
#2 pagination-p2.patch6.86 KBry5n
#2 pagination-p1-with-p2.interdiff.txt5.58 KBry5n
#1 pagination-1.patch3.34 KBLewisNyman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Active » Needs review
FileSize
pagination-1.patch3.34 KB

First kick at a patch.

ry5n’s picture

ry5n CreditAttribution: ry5n commented
FileSize
pagination-p1-with-p2.interdiff.txt5.58 KB
pagination-p2.patch6.86 KB

The previous/next icons could be better, and text-decoration was still being applied on hover. I’ve addressed those, but I’m attaching a patch for further discussion rather than a commit, since I went ahead and actually made a small icon font to see what that would be like to do. It’s got two glyphs in it; I made it using the icomoon web app. I want to get feedback on whether this is a good idea at this point.

I can make the SVG source available; I was going to attach them here but Drupal won’t allow them as attachments. :(

ry5n’s picture

ry5n CreditAttribution: ry5n commented
FileSize
pagination-p3.patch10.85 KB

Patch #2 needs to be full-index and binary due to the webfonts files. Attaching a re-roll; interdiff for text changes is identical. Let me know if this still causes problems with apply.

oresh’s picture

oresh CreditAttribution: oresh commented
FileSize
pagination-p4.patch11.21 KB

is-desabled added for disabled items,
border removed for arrows hover
icon position fixed

ry5n’s picture

ry5n CreditAttribution: ry5n commented
Status: Needs review » Reviewed & tested by the community
FileSize
pagination-4-5.interdiff.txt1.34 KB
pagination-5.patch7.43 KB

Thanks oresh. The webfont icon alignment with inline text should just work without manual tweaking in the CSS – it’s a matter of getting the font metrics right in the actual webfont itself. That is, if we end up using a webfont at all in the end :) Given so many question marks, I’ve left everything as-is for now and just added a todo comment. Also, corrected the spelling of 'desabled': should be 'disabled'. Attached patch is ready for initial merge with master.