When nesting horizontal tabs inside vertical tabs and then viewing it with core's Seven admin theme the label of the horizontal tab is being displayed despite the field_group CSS in place to hide it.

This causes broken looking output.

Patch to follow.

CommentFileSizeAuthor
#2 1945848-field-group-nested-fieldset-unwanted-labels.patch602 bytesDave Reid
#1 field_group-1945848-01.patch819 bytesjamsilver
#1 field_group_broken_hor_tab_title.png8.7 KBjamsilver
#1 field_group_broken_hor_tab_title_fixed.png8.24 KBjamsilver
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jamsilver’s picture

jamsilver CreditAttribution: jamsilver commented
Assigned: jamsilver » Unassigned
Status: Needs work » Needs review
FileSize
field_group_broken_hor_tab_title_fixed.png8.24 KB
field_group_broken_hor_tab_title.png8.7 KB
field_group-1945848-01.patch819 bytes

It's simply because Seven happens to have a CSS selector display:block-ing it which has a higher specificity.

It's simple enough to fix this in field_group by using a selector with two classes in it instead of one =)

I have attached a patch which does the trick. This patch was made against the 7.x-1.x branch head.

Before the fix:
field_group_broken_hor_tab_title.png

After the fix:
field_group_broken_hor_tab_title_fixed.png

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
FileSize
1945848-field-group-nested-fieldset-unwanted-labels.patch602 bytes

I'm actually having this same problem with horizontal tabs inside horizontal tabs. Here is what fixed it for me.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Marked #1858096: Horizontal tabs within Vertical tabs as a duplicate of this issue.

thmnhat’s picture

thmnhat CreditAttribution: thmnhat commented
Status: Needs review » Reviewed & tested by the community

Fixed for me

nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop commented
Status: Reviewed & tested by the community » Fixed

Committed to dev

nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop commented
Status: Fixed » Reviewed & tested by the community

Setting back to reviewed and tested by the community, as pushing to git is currently disabled for drupal projects.

nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop commented
Status: Reviewed & tested by the community » Fixed

pushed to dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit cdca0cf on 7.x-1.x, 8.x-1.x authored by Dave Reid, committed by zuuperman: 
    Issue #1945848 by jamsilver, Dave Reid: Fixed Horizontal tabs legends...