Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#10 | 1946318-action-confirm-form-10.patch | 4.45 KB | kim.pepper |
#10 | interdiff.txt | 1.08 KB | kim.pepper |
#6 | 1946318-action-confirm-form-6.patch | 4.46 KB | kim.pepper |
#6 | interdiff.txt | 2.07 KB | kim.pepper |
#4 | 1946318-action-confirm-form-4.patch | 4.55 KB | kim.pepper |
Comments
Comment #1
mtiftAnything that's "take something from hook_menu and make a route of it" should get the WSCCI-conversion tag
Comment #2
kim.pepperAssigning to me.
Comment #3
kim.pepperDamn. Didn't mean to remove tag.
Comment #4
kim.pepperInitial patch that does this. :-)
Comment #5
tim.plunkettThe conversion looks good, just some nitpicks.
Missing blank line
the $action is redundant
Here and everywhere else: {@inheritdoc}
Blank line after the end of the method before the class
Comment #6
kim.pepperRebased off latest 8.x and applied fixes in #5
Comment #8
kim.pepper#6: 1946318-action-confirm-form-6.patch queued for re-testing.
Comment #9
andypost$action should always exists. No reason to call action_load() - router item does it
please use $this->action - no reason in new variables
Comment #10
kim.pepper1) Discussed this with @andypost in IRC and agreed that actions are not entities, so don't get autoloaded.
2) Removed extra variables
Comment #11
andypostThere's no need to introduce new param converter for single form! Should be green
Comment #12
catchCommitted/pushed to 8.x, thanks!