Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#7 | drupal-aggregator_confirm_form-1946324-7.patch | 4.68 KB | ParisLiakos |
#7 | interdiff.txt | 1.89 KB | ParisLiakos |
#3 | drupal-aggregator_confirm_form-1946324-3.patch | 4.34 KB | ParisLiakos |
Comments
Comment #1
mtiftAnything that's "take something from hook_menu and make a route of it" should get the WSCCI-conversion tag
Comment #2
ParisLiakos CreditAttribution: ParisLiakos commentedpicking this up
Comment #3
ParisLiakos CreditAttribution: ParisLiakos commentedi know #1906474: [policy adopted] Stop documenting methods with "Overrides …" is still rtbc but i was being lazy and used inheritdocs, sue me:)
I have to think about the luck of aggregator_remove() too, lets see what bot says
Comment #5
ParisLiakos CreditAttribution: ParisLiakos commentedrandom failure?
EntityTranslationUITest.php 40
#3: drupal-aggregator_confirm_form-1946324-3.patch queued for re-testing.
Comment #6
ParisLiakos CreditAttribution: ParisLiakos commentedi should kill aggregator_remove()
Comment #7
ParisLiakos CreditAttribution: ParisLiakos commentedActually i won't cause then this will conflict with #1930274: Convert aggregator processors and parsers to plugins
I just added a todo and replaced inheritdocs:(
this should be committable now
Comment #8
Crell CreditAttribution: Crell commentedI agree.
Comment #9
Dries CreditAttribution: Dries commentedCommitted to 8.x.
Comment #10
sunExcuse me.
It is completely beyond me how something like this:
...can remotely turn into this:
This is a 1,200% DX regression. How is that remotely acceptable?
Furthermore, why was this even converted to a "ConfirmFormBase" in the first place?
To my knowledge, aggregator categories and feeds are entities now, and the conversion of delete confirmation forms for entities via EntityFormControllers was and still is on the major todo list for D8.
Comment #11
tim.plunkettThat would be a larger part of #1913618: Convert EntityFormControllerInterface to extend FormInterface. But yes, see #1938600: Add a FormInterface replacement for confirm_form() for the details on the future of confirm_form().