Part of #1945406: [meta] Convert all of confirm_form() to ConfirmFormBase

CommentFileSizeAuthor
#11 drupal-block_confirm_form-1946334-11.patch4.46 KBmtift
#11 interdiff.txt1.47 KBmtift
#8 drupal-block_confirm_form-1946334-8.patch4.69 KBmtift
#8 interdiff.txt690 bytesmtift
#6 drupal-block_confirm_form-1946334-6.patch4.59 KBmtift
#6 interdiff.txt895 bytesmtift
#3 drupal-block_confirm_form-1946334-3.patch4.59 KBmtift
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Issue tags: +WSCCI-conversion

Anything that's "take something from hook_menu and make a route of it" should get the WSCCI-conversion tag

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Assigned: Unassigned » mtift

It take this one.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Active » Needs review
FileSize
drupal-block_confirm_form-1946334-3.patch4.59 KB

This feels very close, but for some reason, the $entity object is not getting passed in buildForm().

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented 
+++ b/core/modules/block/lib/Drupal/block/Form/AdminBlockDeleteForm.phpundefined
@@ -0,0 +1,72 @@
+  public function buildForm(array $form, array &$form_state, Block $entity = null) {

This should be Block $block = NULL

+++ b/core/modules/block/lib/Drupal/block/Form/AdminBlockDeleteForm.phpundefined
@@ -0,0 +1,72 @@
+    $this->block = $entity;

And $this->block = $block;

The parameters of blockForm have to match what is in the {slug} in the route.

Status: Needs review » Needs work

The last submitted patch, drupal-block_confirm_form-1946334-3.patch, failed testing.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Needs work » Needs review
FileSize
interdiff.txt895 bytes
drupal-block_confirm_form-1946334-6.patch4.59 KB

This is working for me in my local dev environment, so I'm feeling hopeful.

Status: Needs review » Needs work

The last submitted patch, drupal-block_confirm_form-1946334-6.patch, failed testing.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Needs work » Needs review
FileSize
interdiff.txt690 bytes
drupal-block_confirm_form-1946334-8.patch4.69 KB

Hopefully fixed the remaining fail by adding (back) the message that appears after the block has been deleted

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented

well besides inheritdocs this is ready
#1906474: [policy adopted] Stop documenting methods with "Overrides …"

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs review » Needs work
mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.47 KB
drupal-block_confirm_form-1946334-11.patch4.46 KB

Here's an updated patch that uses inheritdocs

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

thanks!
ready to go if bot agrees

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.