Part of #1945406: [meta] Convert all of confirm_form() to ConfirmFormBase

CommentFileSizeAuthor
#6 filter-confirm-form-1946410-6.patch10.68 KBtim.plunkett
#6 interdiff.txt880 bytestim.plunkett
#4 filter-confirm-form-1946410-4.patch10.66 KBtim.plunkett
#4 interdiff.txt1.62 KBtim.plunkett
#2 filter-confirm-form-1946410-2.patch10.05 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Assigned: Unassigned » tim.plunkett

Working on this.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
FileSize
filter-confirm-form-1946410-2.patch10.05 KB

Only one in this module! Woo.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
interdiff.txt1.62 KB
filter-confirm-form-1946410-4.patch10.66 KB

I actually needed to register the access check.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
interdiff.txt880 bytes
filter-confirm-form-1946410-6.patch10.68 KB

Whoops, forgot to change the variable names in FilterFormat::disable(), and to return $this.

Status: Needs review » Needs work
Issue tags: -FormInterface, -WSCCI-conversion

The last submitted patch, filter-confirm-form-1946410-6.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review

#6: filter-confirm-form-1946410-6.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +FormInterface, +WSCCI-conversion

The last submitted patch, filter-confirm-form-1946410-6.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Postponed

Blocked on #1945418: New-style placeholders in menu_router table break breadcrumbs, menu tree, etc

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Postponed » Needs review

#6: filter-confirm-form-1946410-6.patch queued for re-testing.

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

filter_format_disable is dead, good stuff, we should post a change notification once this is in i guess

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.