Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#7 | node-1946434-7.patch | 32.07 KB | tim.plunkett |
#2 | node-confirm-form-1946434-2.patch | 9.94 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettGoing to try this.
Comment #2
tim.plunkettStarted here: http://drupalcode.org/sandbox/tim.plunkett/1698392.git/shortlog/refs/hea...
We'll need to have #1947432: Add a generic EntityAccessCheck to replace entity_page_access() and #111715: Convert node/content types into configuration first. I'll postpone this after the bot comes back.
Comment #3
tim.plunkettComment #4
Crell CreditAttribution: Crell commentedFor the bot.
It's not that hard, is it? ;-) Yes, needs a docblock.
$type is still a stdClass? We have those? Why? :-) (Not something to fix here; just noting it.)
This implies we need an injected database object instead.
Although perhaps this suggests we need a higher level method on another service instead, since injecting the DB into the form here seems wrong.
Is this not a service yet?
I don't think menu_router_rebuild() addresses the new routing system, so we need to do that here, too. (That is a service.)
Comment #5
tim.plunkettI think every single thing except my lazy @todo that @Crell points out is part of
#512026: Move $form_state storage from cache to new state/key-value system#111715: Convert node/content types into configuration.Comment #6
tim.plunkettForgot to unpostpone this! Still on this.
Comment #7
tim.plunkettCompletely re-written from scratch, since all of the confirm forms for node types were handled in the ConfigEntity conversion.
Comment #8
jibranThis looks awesome RTBC for me but can you explain these maybe I am wrong.
I think it should be NodeStorageController
And I think it should be NodeAccessController
Comment #9
tim.plunkettNo, we don't typehint with class, only with interfaces.
There is nothing special about NodeStorageController, which is why it doesn't have its own interface.
Comment #10
jibran:)
Comment #11
pwolanin CreditAttribution: pwolanin commentedHaving discussion with effulgentia, wim, and jbeach - we need a follow-up to remove the duplication here and generate the entity routes (or at least path patterns) based on the entity annotation.
Comment #12
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks!
Comment #13
tstoecklerSimilar to #4: Shouldn't this query be in a method on the storage controller? If so, I'll open a follow-up issue, just wanted to check first.
Comment #14
Crell CreditAttribution: Crell commentedActually, it looks like it should be a method on NodeInterface.
Comment #15
tstoecklerOpened #2040545: Move database query out of \Drupal\node\Access\NodeRevisionAccessCheck for that.
Comment #16
tim.plunkett