State Field Does Not Hold Value [#19465]

Comment	File	Size	Author
#11	location-province-19465.patch	1018 bytes	smk-ka

#10	location-province-19465.patch	811 bytes	smk-ka

Comment #1

ankur CreditAttribution: ankur commented 25 March 2005 at 23:18

Assigned:

Unassigned

» ankur

Log in or register to post comments

Comment #2

ankur CreditAttribution: ankur commented 26 March 2005 at 00:03

Fixed it with a patch: http://cvs.drupal.org/viewcvs/drupal/contributions/modules/location/loca...

In the future: Maybe I should upload the patch here first and then commit.

-Ankur

Log in or register to post comments

Comment #3

joshk CreditAttribution: joshk commented 28 March 2005 at 19:30

Not fixed completely. The error still occurs if an admin has set up a content-type which allows state/province, but does not allow for country. This is because with the following login in location_api2form, if the country is not set, the province field will remain unset in $translated:

if ($key == 'province') {
  if (strlen($value) && isset($location['country']) && strlen($location['country']) && $location['province'] != 'xx' && $location['country'] != 'xx') {
    $translated['province'] = $location['country'] .'-'. $value;
  }
}
else {
   $translated[$key] = $value;
}

A lot of other functionality seems to be missing when the country field is disabled as well (e.g. map links). Maybe it should not be optional?

Log in or register to post comments

Comment #4

ankur CreditAttribution: ankur commented 30 March 2005 at 03:05

Fixed for real this time! (by the [gasp] multi-taskin patch at http://drupal.org/node/19604 )

I'm trying to get the module to detect when a person has selected a state from the province drop down but not the appropriate country.

The "value" attribute for the province HTML select options go by us-CA for California, us-WA for Washington state and so on. The idea is that someone can later write a JavaScript that narrows down the province selection to the appropriate states when a country is selected. However, currently, if someone selects a state but forgets to select a country, why not complete the task for them?

-Ankur

Log in or register to post comments

Comment #5

(not verified) CreditAttribution: commented 13 April 2005 at 03:16

Log in or register to post comments

Comment #6

seutje CreditAttribution: seutje commented 17 March 2010 at 14:43

Status:

Closed (fixed)

» Active

Think I just hit the same problem, not using CCK, just 6.x-3.x-dev Location. Default country is set to "Belgium" and is omitted from the node/add form, default state/province is set to "Antwerpen", but isn't omitted from the node/add form, now when I first submit a node, it'll do things as expected, but when I edit the node, the state/province field will say "VAN"

this does not happen when previewing, only when editing

Log in or register to post comments

Comment #7

YesCT CreditAttribution: YesCT commented 11 April 2010 at 06:28

seutje, please look through the issue queue for other issues involving "defaults" and see if any of them might be related to what you are seeing...

Log in or register to post comments

Comment #8

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 23 November 2010 at 00:39

Am seeing this myself in v6.x-3.1.

Log in or register to post comments

Comment #9

casmbu CreditAttribution: casmbu commented 4 February 2011 at 13:28

I am seeing this issue in the v6.x-3.x-dev.

Log in or register to post comments

Comment #10

smk-ka CreditAttribution: smk-ka commented 5 February 2011 at 03:21

Status:

Active

» Needs work

File	Size
location-province-19465.patch	811 bytes

With the province display option set to "Display full province name" and no default value for province specified, the hack as in the attached patch was required to make the province value stick during node preview. Depending on your specific settings for the province field it may or may not work, hence "needs work".