As I understand correctly, for now, end of auction is detect only when somebody visit auction node. Then the commerce_auction_node_view is called and this hook detects if auction ended and if product should be added to cart to winner.
I suggest that it could work with cron, so product is placed in cart without needing to visit node page.

I think it can be achieved to move code from commerce_auction_node_view to hook_cron function and make some simple edits.
If you don't mind, I can write a patch.

CommentFileSizeAuthor
#9 commerce_auction-use-cron-1947466-9.patch6.61 KBlauriii
#8 commerce_auction-use-cron-1947466-8.patch6.73 KBlauriii
#7 commerce_auction-use-cron-1947466-7.patch6.73 KBlauriii
#5 commerce_auction-use-cron-1947466-7534009.patch12.44 KBswim
#4 commerce_auction-use-cron-1947466-7534009.patch30.42 KBswim
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pinkonomy’s picture

pinkonomy CreditAttribution: pinkonomy commented

Could you write a also a patch for this?thanks

pinkonomy’s picture

pinkonomy CreditAttribution: pinkonomy commented

Also,the best would be to automatically,when an auction ends,the product to be placed inside the cart.What about using a rule firing on this?Since I think waiting for cron to run can take a lot of time.
thanks

swim’s picture

swim CreditAttribution: swim commented

FYI,

if anyone still needs this I had to quickly throw the feature together today. Once I get home I'll upload the patch. The patch will also fix these issues;

  • Saving auction node without product causes fatal error
  • Groups line items belonging to the same user so we don't end up with multiple carts

Cheers,

swim’s picture

swim CreditAttribution: swim commented
Status: Active » Needs review
FileSize
commerce_auction-use-cron-1947466-7534009.patch30.42 KB

Needs some more love but for anyone else that needs this.

swim’s picture

swim CreditAttribution: swim commented
FileSize
commerce_auction-use-cron-1947466-7534009.patch12.44 KB

Ahhg rerolled without the license.txt.

farhadhf’s picture

farhadhf CreditAttribution: farhadhf commented

Hey,

Thanks for the patch - I'm free for the next 2 days, planning to do some cleanup in commerce_auction issue queue :)

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii commented
Issue summary: View changes
FileSize
commerce_auction-use-cron-1947466-7.patch6.73 KB

Rerolled last patch

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii commented
FileSize
commerce_auction-use-cron-1947466-8.patch6.73 KB 
+++ b/commerce_auction.module
@@ -198,39 +205,83 @@ function commerce_auction_find_field_name($entity_type, $bundle, $field_type) {
+  ¶

Removed whitespaces

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii commented
FileSize
commerce_auction-use-cron-1947466-9.patch6.61 KB

Removed commerce_product_line_item_new call which wasnt needed

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented

Closed #2483657: Adding winning bid to user's cart only works intermittently and #1884208: Cart is empty after won auction as duplicates.