Make AIS work without Javascript

Ok, great! I will have some time later in spring. I will use the .dev branch as a base for patches, right?

So, here we go. Sorry for the delay, business took me off ;)

"Brief" description of what this first attempt does:

* Build combined @import/@media queries depending on each existing adaptive style (taken from the variables array).
* Issue these as an inline style on every page. This forces a (suitable) browser to import the "file" corresponding with its actual viewport dimensions.
* When the browser requests the "file" (actually a page callback with a wildcard which is nothing other than the matching style's machine name), it returns a dummy file and sends a cookie to the client.
* On the next (see below) request, the user gets the image styles best matching his viewport.

How to get rid of the delay issue in general:
At a glance, it looks as if without JS, there could be no instant matching. But extending the above approach, here's a basic idea of how to solve it completely without JS (see even more below). As you actually alter the image style callback anyhow by redirecting "image_style_deliver", why not extend this scheme. Roughly (pseudo code):

if (!find_any_ais_cookie()) {
  // Replace the image href with a common callback function (and an image ID or whatever).
  replace_image_url('ais_gateway', $image_id);
}

/**
 * Image gateway callback.
 */
function ais_gateway($image_id) {
  $current_user_style = $_COOKIE['Drupal.visitor.ais'];
  drupal_goto(/path/to/image/$current_user_style);
}

The idea behind this is simple: If no cookie has been set, retrieve the images through a redirector. So when the browser loads the first page ever, he will
a) load the virtual CSS file and thus have a cookie.
b) load the image(s) via the redirector.
c) Once the redirect path is requested, the browser already has the cookie from the virtual css request.
The redirector will only appear if no ais cookie is found. Otherwise everything works like it does right now.

JS note:
Of course we would not drop the JS. First, the $(window).resize event may provide more recent data. Then, JS may be useful to force a replacement of images with the best-matching style derivative in realtime. And then, both JS and the fallback can coexist in peace, so why sacrifice someting.

Finally, find my first patch proposal. Looking forward to getting your opinion!

Notabene: In order to use the user_cookie_ API functions, we really need to change your ais cookie to the correct Drupal namespace (Drupal.visitor.).

PS.

Just thought again. In the end, your RewriteRule does not do anything else at all than redirect using an HTTP 302.

So in the end, the redirector callback should really be worth a try. I will soon give it a shot, but first I am going to wait for your comments on these rather major changes (and hope you won't mind my feeling free to propose that much). :)

Good night!

Forgot to change the cookie name for the hook_requirements implentation. Updated patch attached.

Great to hear that you like it. So, while you continue testing and I am looking forward to your finding potential issues, I will examinate on the redirect trick (to work around the one-request-delay mentioned above).

I understand your concerns regarding the Cookie ./. .htaccess issue, you have a point. I will thus split it up the next days and create different patches alright. I will reuse the existing separate cookie issue for this purpose.

After all it is a pleasure to contribute to useful projects - like yours definitely is. :-)

I rerolled the cookie thing by now. As there is no 2.x branch yet, I left some @todo comments so we can find the problematic spots right away. I also added some more CS/API related comments. We should look after those in a free minute. Also I fixed some unnecessary double-quoted strings where single quotes suffice; why sacrifice CPU withoud need.

Here is a patch just like the one above but with your legacy cookie name. Let's just include this stuff and once it is, I will look after the redirect thing (we should open a separate issue for this IMO, in order to reduce confusion).

David

Contact me if anything happens here, I am cleaning up my queue and unfollowing.