Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I am having an issue with this module on a site secured by ssl or https. The module is loading images over http by default even though the site is set up for https already. I tried clearing the cache already and I also tried disabling and reenabling the module. Did a search in the issue & didn't see any documentation o this. Need help with this asap!
Comment | File | Size | Author |
---|---|---|---|
#9 | SSL-support-1949074-9.patch | 30.05 KB | junaidpv |
#5 | 1949074-5-SSL-support.patch | 30.54 KB | mukhsim |
#4 | protocol_relative.diff | 30.66 KB | ben.bunk |
Comments
Comment #1
debo7debo CreditAttribution: debo7debo commentedSo I found the problem in the "socialmedia.widgets.inc" file. All the javascripts and images being loaded need to be from the https protocol, not http. This will prevent browsers from displaying message that "not all the content on the site are secure" when being loaded on a secure site. I found the problems in the sections of the file below.
I don't know how to write patches so I changed it manually in my file, so if someone can write a patch for this and submit it that would be great for everyone.
Comment #2
debo7debo CreditAttribution: debo7debo commentedStill finding an "addthis" script still using http:// in the source code of a rendered page, but I can't find any more http:// in the socialmedia module files.
Here is the code:
<script src="http://s7.addthis.com/js/250/addthis_widget.js#username=" type="text/javascript"></script>
Comment #3
debo7debo CreditAttribution: debo7debo commentedOk so I fixed that final piece. Apparently, the widgets generated by setup wizard have to regenerated by another run of the setup wizard. Downside of this is that if you customized placements and restrictions on blocks and other things, the setup wizard resets all of that.
Comment #4
ben.bunk CreditAttribution: ben.bunk commentedAdding a patch to switch all external paths to protocol relative to prevent http/https mismatch problems.
I have to apply patches with (patch -p1 < file.patch) but you might be able to use git apply.
Comment #5
mukhsim CreditAttribution: mukhsim commentedPlease find attached correct patch.
Comment #6
mdawe CreditAttribution: mdawe commentedThis does not appear to be merged into release yet?
Comment #7
dfletcher CreditAttribution: dfletcher commentedWould be great if this fix could get rolled into the latest version. Every time this module is updated I have to reapply patch since my client forces visitors to https via htaccess. I usually hear about this after someone applies updates and then opens a bug report with missing social media buttons. Would be fantastic if client didn't have to see this bug again. Is seems pretty simple to remove http: and use CDN style URLs, or am I missing something here?
Comment #8
Exigo CreditAttribution: Exigo commentedSomehow I could not apply correctly any of these patches, but I just manually replaced http:// with https://. I would also need this functionality to work without patching.
Comment #9
junaidpvHere is the rerolled patch for latest dev.
Comment #10
kyletaylored CreditAttribution: kyletaylored at LevelTen Interactive commentedThanks everyone! Rolling this in now, also removing a couple debug statements and unused variables.
Comment #11
kyletaylored CreditAttribution: kyletaylored at LevelTen Interactive commented