Hi guys,
Thanks a lot for the great work and I have been seeing the changes in the version control (commits).
It seems several new settings have been introduced:
sharethis_publisherID
However it seems the uninstall function chosen_uninstall only deletes the variable sharethis_publisherID, in the sharethis.install file.
I have tried to make a patch, attached to this ticket, to try to resolve this issue: Remove_all_settings_variables_during_module_uninstall.patch
I would tend to think calls for deleting variables (variable_del) should probably be comitted together in the .install file when the .module or .inc files are modified to add variables (variable_get, usually in module's configuration settings form).
I would greatly appreciate if you could take some time to test/review the patch and give us your feedback on this feature request.
Any feedback, comments, testing is highly appreciated.
Thanks in advance.
Comment | File | Size | Author |
---|---|---|---|
Remove_all_settings_variables_during_module_uninstall.patch | 439 bytes | Gaofengzzz | |
Comments
Comment #1
DYdave CreditAttribution: DYdave commentedChanging issue status to needs review for automated testing of patch and as an attempt to get more feedback and comments from other users.
Any feedback, testing, reporting and reviews would be highly appreciated.
Thanks to all in advance!
Comment #2
Gaofengzzz CreditAttribution: Gaofengzzz commentedThanks to @sreynen, who allowed me to obtain module maintainer's rights, I was able to get this moving into code.
This change has been committed at: 6.x-1.x: 804c7ce, 7.x-1.x: 3d61c94.
Marking this as fixed.
Please let me know if you would have any other questions, comments, issues or concerns on any of these changes, I would be glad to provide more information.
Thanks again for your help and interest.
Cheers!