Just noticed a missing word here: http://api.drupal.org/api/drupal/includes%21common.inc/function/drupal_a...

"This function can be called as long the headers aren't sent."
should be
"This function can be called as long as the headers aren't sent."

CommentFileSizeAuthor
#6 documentation-for-drupal_add_html_head-1952354-6.patch501 bytesrobertcharlesfox
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Issue tags: +Novice

Looks like the 8.x documentation was fixed at some point, so this is just a 7.x issue. Should be a good Novice project!

madhavvyas’s picture

madhavvyas CreditAttribution: madhavvyas commented
Assigned: Unassigned » madhavvyas
laurencemercer’s picture

laurencemercer
Primary language English
CreditAttribution: laurencemercer commented
Assigned: madhavvyas » laurencemercer

Great - I'll patch it.

laurencemercer’s picture

laurencemercer
Primary language English
CreditAttribution: laurencemercer commented
Assigned: laurencemercer » Unassigned

Bah - sorry madhavvyas. It's all yours :)

robertcharlesfox’s picture

robertcharlesfox CreditAttribution: robertcharlesfox commented
Status: Needs review » Active

my first Drupal patch. Fixed the typo as indicated in the issue description.

robertcharlesfox’s picture

robertcharlesfox CreditAttribution: robertcharlesfox commented
Assigned: Unassigned » robertcharlesfox
Status: Active » Needs review
FileSize
documentation-for-drupal_add_html_head-1952354-6.patch501 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Assigned: robertcharlesfox » jhodgdon
Status: Active » Reviewed & tested by the community

Thanks for all the interest, and thanks for the patch! Ready to be committed.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Fixed

Went ahead and stole this one from you, @jhodgdon :)

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/de6e29d

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Committing things I haven't gotten around to committing is not stealing. :) Thanks David!

Automatically closed -- issue fixed for 2 weeks with no activity.