Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I created a trivial patch to split apachesolr_index_entity_to_documents() into two functions.
This patch adds apachesolr_entity_to_documents_delegate() to simply isolate some code from apachesolr_index_entity_to_documents(). That simplifies some stuff in apachesolr_multilingual_apachesolr_index_documents_alter() where this same code is required, too.
Currently the code is redundant in apachesolr_multilingual.module which will be hard to maintain and therefore should be avoided.
Comment | File | Size | Author |
---|---|---|---|
#14 | 1954302-14.patch | 4.2 KB | mkalkbrenner |
#10 | 1954302.patch | 2.97 KB | mkalkbrenner |
#4 | apachesolr_index_entity_to_documents.patch | 3.02 KB | mkalkbrenner |
#3 | apachesolr_index_entity_to_documents.patch | 2.66 KB | mkalkbrenner |
delegate.patch | 1.07 KB | mkalkbrenner | |
Comments
Comment #2
Nick_vhI think we should define the variable types (object, array, etc..)
Give it a description of what exactly it returns
Comment #3
mkalkbrennerI completed the documentation and renamed the new function.
Comment #4
mkalkbrennermade a mistake, the reseting the user must still happen in apachesolr_index_entity_to_documents(). Now the tests should pass.
Comment #5
mkalkbrennerComment #7
mkalkbrennerComment #8
mkalkbrenner#4: apachesolr_index_entity_to_documents.patch queued for re-testing.
Comment #10
mkalkbrennerComment #11
mkalkbrenner"major" for release
Comment #12
mkalkbrennerComment #13
Nick_vhPushed to 7.x-1.x
Comment #14
mkalkbrennerI ported to patch back to 6.x-3.x.
To backport apachesolr_multilingual back to drupal 6 it's essential that this patch gets committed.
Comment #15
mkalkbrennerComment #17
mkalkbrenner