Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up

Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionalities
Create patch and upload for the testbot.

core/modules/translation_entity/translation_entity.admin.js: line 42, col 28, Expected '===' and instead saw '=='.

CommentFileSizeAuthor
#1 1955286-jshint.patch588 bytesdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Active » Needs review
FileSize
1955286-jshint.patch588 bytes

suggest committer to use "git pre-commit hook" :)

Status: Needs review » Needs work
Issue tags: -JavaScript clean-up

The last submitted patch, 1955286-jshint.patch, failed testing.

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs work » Needs review
Issue tags: +JavaScript clean-up

#1: 1955286-jshint.patch queued for re-testing.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Reviewed & tested by the community

thanks :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 2d6ed6c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.