This will allow modernizr_api_list() to know what module is implementing which test, and clean up the data for the new admin page redesign.

WARNING: THIS WILL BREAK THE ADMIN PAGE.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rupl’s picture

Status: Active » Fixed

Thanks Ian, this is great. Everyone agrees the need to explicitly name the module that requires the test was silly. Here's an example: #1946216-5: @font-your-face: Integration with Modernizr 7.x-3.x

One comment:

+++ b/modernizr.moduleundefined
@@ -569,16 +655,18 @@ function modernizr_api_list() {
+  // Three ways to add information to the info array.
+  // Indexed array, with just the name as the value.
+  $items[] = 'cssclasses';
+
+  // Indexed array with a sub-array that must include a 'name' key.
+  $items[] = array(
+    'name' => 'printshiv',
   );
 
+  // Associative array with the name as the key.
+  $items['load'] = array();
+

I like the idea of documenting the different approaches, but that's what modernizr.api.php is for. We'll declare all three using one approach and document the alternatives in the API file later.

I'm going to commit this with the change I just noted, but it won't show up in dev til I fix the admin UI. Thanks for the patch!

iamcarrico’s picture

Agreed--- I left these in here for testing purposes. Making sure we dont break any of them in future development.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

rupl’s picture

I'm being a bad maintainer but this is not yet in the dev branch on account of the admin UI. Just FYI for anyone who wanders by.

rupl’s picture

ok this has finally been pushed to dev. whew!