Location Email arbitrarily constrains field to 31 chars [#1958476]

Title says it all. The location email field isn't big enough for some emails. Granted, there may be no limit everyone is happy with, but 31 characters seems arbitrary and low.

Comment	File	Size	Author
#8	location-Removed_arbitrary_maxlength_on_email-1958476-8.patch	616 bytes	cbeier
#8
#5	location-Removed_arbitrary_maxlength_on_email-1958476-5.patch	584 bytes	redijedi
#5
#1	location-email-1958476-1_0_0.patch	530 bytes	redijedi
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

redijedi CreditAttribution: redijedi commented 2 April 2013 at 02:27

File	Size
location-email-1958476-1_0_0.patch	530 bytes

Comment #2

podarok

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 2 April 2013 at 16:08

Version:	7.x-3.0-alpha8	» 7.x-3.x-dev
Status:	Active	» Needs review

bot?

Comment #3

2 April 2013 at 17:28

Status:

Needs review

» Needs work

The last submitted patch, location-email-1958476-1_0_0.patch, failed testing.

Comment #4

podarok

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 2 April 2013 at 18:28

You should provide patch in git diff format
http://drupal.org/patch

Comment #5

redijedi CreditAttribution: redijedi commented 2 April 2013 at 19:28

File	Size
location-Removed_arbitrary_maxlength_on_email-1958476-5.patch	584 bytes

Comment #6

podarok

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 2 April 2013 at 19:54

Status:

Needs work

» Needs review

You should bump status to needs review for bot...

Comment #7

rooby CreditAttribution: rooby commented 8 April 2013 at 12:08

Status:

Needs review

» Needs work

Omitting the maxlength value will make it 128 characters.

I would recommend setting it to 254 characters, because that is what the database column for this field will hold and it is also the character limit for a valid email address.