Nginx would really like a Content-Length of 0 for any DELETE requests. I'm currently adding the header in ServicesClientConnection::delete(), patch attached.

CommentFileSizeAuthor
#6 1959248-support-nginx-delete-add-content-length-5.patch742 bytesmhrabovcin
#4 1959248-support-nginx-delete-add-content-length-4.patch834 bytesjpstrikesback
Support-nginx-delete-add-content-length.patch679 bytesjpstrikesback

Comments

jpstrikesback’s picture

jpstrikesback commented
Title: Nginx DELETE request returns 411 Length Required. Content-Length = 0 required. » DELETE request to Nginx returns 411 Length Required. Content-Length = 0 required.
jpstrikesback’s picture

jpstrikesback commented
Status: Active » Needs review
mhrabovcin’s picture

mhrabovcin commented
Status: Needs review » Needs work

I'd like to see this as part of REST plugin rather than services client class because this doesn't need to necessary apply on XML-RPC server or other servers.

jpstrikesback’s picture

jpstrikesback commented
StatusFileSize
new 1959248-support-nginx-delete-add-content-length-4.patch834 bytes

Good catch.

jpstrikesback’s picture

jpstrikesback commented
Status: Needs work » Needs review
mhrabovcin’s picture

mhrabovcin commented
StatusFileSize
new 1959248-support-nginx-delete-add-content-length-5.patch742 bytes

What about adding general Content-Length support to Rest plugin?

jpstrikesback’s picture

jpstrikesback commented

I like that, I'll test that and get back here

mhrabovcin’s picture

mhrabovcin commented

Did you tested if fix was working correctly?

jpstrikesback’s picture

jpstrikesback commented

I just tested it and there are a few items:

- $this->data should be $request->data
- $request->data is at least sometimes an empty array (so strlen() breaks things as it throws a warning) (i.e. when doing a DELETE)

The only real issue is the array, which may be only set on DELETE? I don't know offhand.

jpstrikesback’s picture

jpstrikesback commented
Status: Needs review » Needs work