Problem

The status field in the sms_track table within the sms_track module only accepts values up to 255 as a tinyint in MySQL. This is an issue as the status codes defined in the sms.module file go up to a maximum value of 500, attempting to store one of these codes will result in either a truncated value being stored or a MySQL error.

Proposed Resolution

Change the field to a smallint (size => small), so that all status codes are accepted.

CommentFileSizeAuthor
#1 smsframework-tracking-status-field-too-small-1959802-1.patch896 bytessd46
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sd46’s picture

sd46 CreditAttribution: sd46 commented
Assigned: sd46 » Unassigned
Status: Active » Needs review
FileSize
smsframework-tracking-status-field-too-small-1959802-1.patch896 bytes

Patch to fix issue, and add update function in .install file

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Issue summary: View changes
Related issues: +#2282309: Numeric value out of range: 1264 Out of range value for column 'status', +#2295013: Upgrade path: 'status' column in sms_track table is too small

I saw this patch too late :(!!! Some part of this issue has been fixed in another similar issue where this patch would have come in handy. Thanks @sd46 for the elegant solution :)

Related issues: #2282309: Numeric value out of range: 1264 Out of range value for column 'status' and #2295013: Upgrade path: 'status' column in sms_track table is too small

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Needs review » Fixed

Patch committed / pushed to 7.x-1.x. Thanks :)

  • almaudoh committed 6978312 on 7.x-1.x 
    Issue #1959802 by almaudoh | sd46: Fixed Tracking Status Field too Small...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.