The conditional that is checking the FACEBOOK_PULL_CACHETIME is incorrect, resulting in the cache NEVER being recreated after it has expired (unless the cache entry is cleared by some other means).

CommentFileSizeAuthor
#7 fix_incorrect_conditional_cachetime-1960496-7.patch1.13 KBkyuubi
#2 fix_incorrect_conditional_cachetime-1960496-2.patch1.13 KBmdeltito
#1 fix_incorrect_conditional_cachetime-1960496-1.patch1.13 KBmdeltito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mdeltito’s picture

mdeltito CreditAttribution: mdeltito commented
Status: Active » Needs review
FileSize
fix_incorrect_conditional_cachetime-1960496-1.patch1.13 KB
mdeltito’s picture

mdeltito CreditAttribution: mdeltito commented
FileSize
fix_incorrect_conditional_cachetime-1960496-2.patch1.13 KB

this version is correct

mnarendrak’s picture

mnarendrak CreditAttribution: mnarendrak commented

Hi,
Even though i changed the cache expiration logic to
if (!$cache || $cache->created + FACEBOOK_PULL_CACHETIME < time()) , its not working.
After flushing all caches of my drupal applcation, then only facebook latest feeds are coming.
Please any one guide me how to resolve the issue.
Thank you

esbite’s picture

esbite CreditAttribution: esbite commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

This patch works great for me. Please release a new version with this fix :)

mdeltito’s picture

mdeltito CreditAttribution: mdeltito commented
daveferrara1’s picture

daveferrara1 CreditAttribution: daveferrara1 commented
Status: Reviewed & tested by the community » Closed (fixed)

Issue #1960496 by mdeltito: Incorrect logic for cache expiration

kyuubi’s picture

kyuubi CreditAttribution: kyuubi commented
Status: Closed (fixed) » Needs review
FileSize
fix_incorrect_conditional_cachetime-1960496-7.patch1.13 KB

Hey,

The provided patch no longer applies.

Can I ask why it has never been committed as the issue still persists?

Here is a rerolled version of the patch, please commit otherwise people might overlook this and use it without posts ever being cached.

daveferrara1’s picture

daveferrara1 CreditAttribution: daveferrara1 commented

Yes. Let me have a look.

mdeltito’s picture

mdeltito CreditAttribution: mdeltito at Phase2 commented

@daveferrara1 it looks like the wrong version of my original patch was applied. The update from @kyuubi fixes this appropriately.

EDIT: see here https://www.drupal.org/commitlog/commit/23464/8e4869693b493e1154c2359b2a...

note that patch-1 was applied instead of patch-2

daveferrara1’s picture

daveferrara1 CreditAttribution: daveferrara1 commented

Yeah I see how we got the less than and greater than mixed up in there. I'll get it into 7.x-2.2

daveferrara1’s picture

daveferrara1 CreditAttribution: daveferrara1 commented

NVM was thinking maybe 20 minutes should be changed. I guess if someone wants they can change it.

daveferrara1’s picture

daveferrara1 CreditAttribution: daveferrara1 commented
Status: Needs review » Closed (fixed)

Issue #1960496 by mdeltito, kyuubi: Incorrect logic for cache expiration