Using shorthand color values, such as #F00 instead of #FF0000, will cause affectFavicon() to throw an error, specifically the issue being that splitColor doesn't seem to be able to handle this format.

The error it gives is:
Cannot call method 'join' of null

CommentFileSizeAuthor
#3 1960664-use-long-color-names.patch11.11 KBStevel
#1 1960664-use-long-color-names.patch9.54 KBStevel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Stevel’s picture

Stevel CreditAttribution: Stevel commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Active » Needs review
FileSize
1960664-use-long-color-names.patch9.54 KB

This patch changes all colors used to be 6 characters and to lowercase (since the colorpicker also uses lowercase).

Should existing config be updated as well to migrate from 3 to 6-character colors?

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso commented

Looks good! I'll be merging this asap.

Stevel’s picture

Stevel CreditAttribution: Stevel commented
FileSize
1960664-use-long-color-names.patch11.11 KB

This patch adds a validation function to the settings form to ensure that the color format is correct.

Stevel’s picture

Stevel CreditAttribution: Stevel commented
Issue summary: View changes

Note: don't use the file listed in this comment! Use the one from the recent files above (or from comment #3)

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso commented

Commited and pushed to dev.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.