American date format hardcoded [#1962540]

I think this issue is still active because the way format_date() handles medium format. If a custom format is set when using type medium it always uses the custom format. (don't really know why). https://api.drupal.org/api/drupal/includes%21common.inc/function/format_...

In includes/redhen.forms.inc

$default_value = isset($_GET['properties'][$key]) ? $_GET['properties'][$key] : NULL;
if ($prop['type'] == 'date' && !empty($default_value)) {
  $default_value['from'] = ($default_value['from'] == '') ? '' :
    format_date(strtotime($default_value['from']), 'medium', 'm/d/Y');
  $default_value['to'] = ($default_value['to'] == '') ? '' :
    format_date(strtotime($default_value['to']), 'medium', 'm/d/Y');
}

We should either switch from using type medium to short OR remove format 'm/d/Y'.

Log in or register to post comments

Comment #4

28 May 2014 at 03:57

Commit 5e214f4 on 7.x-1.x, tests, redhen-donation by levelos:

#1962540 by levelos: Use format_date() when formatting date strings in...

Log in or register to post comments

Comment #5

23 June 2014 at 23:33

Commit 5e214f4 on 7.x-1.x, tests, redhen-donation, relation-roles by levelos:
```
#1962540 by levelos: Use format_date() when formatting date strings in...
```

Log in or register to post comments

Comment #6

25 July 2014 at 21:21

levelos committed 5e214f4 on relation-roles

#1962540 by levelos: Use format_date() when formatting date strings in...

Log in or register to post comments

Comment #7

levelos CreditAttribution: levelos commented 19 August 2014 at 20:19

Status:

Needs work

» Fixed

Good catch, fixed.

Log in or register to post comments

Comment #8

19 August 2014 at 20:19

levelos committed ba691e0 on 7.x-1.x
```
#1962540: American date hardcoded.
```

Log in or register to post comments

Comment #9

2 September 2014 at 20:20

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #10

edward.peters CreditAttribution: edward.peters commented 6 May 2015 at 09:40

Version:	7.x-1.1	» 7.x-1.x-dev
Status:	Closed (fixed)	» Needs review

Isn't this still an issue? So far as I can see, the date format is hard-coded to US format, and as a European I badly need it to be configurable for other formats so that I don't have to hack the module (as I have done so far). Any advice/help welcome.