I have a Location CCK field attached to Users. I want to do a User proximity search in a view. But it fails, because the locations attached to my users look like this:

http://f.75th.me/image/161c2t3Z3V1T

Certainly those first three columns should be inverted; the nids and vids should all be zero, and the uids should be 10, 11, and 12. Manually making this change to the database makes the search work beautifully.

Clearly the ideal thing would be to redesign the module so that Location filters are specified by field like everything else, rather than just by node or user the old way. But in the meantime, some logic to fill out these database entries correctly would be welcome. I don't have time to dig into it right now, but maybe next week sometime I'll take a crack at it, if no one else does first.

Comments

It took me some while to track down why no "Bubbles" are shown on the gmap, by analysing the SQL Commands.

Open the file modules/location/contrib/location_cck/location_cck.module

Find the HOOK location_cck_field_update at line 178

Just extend the ARRAY with the code:

  'uid' => $entity->uid,

The final function should look like this:

<?php
/**
* Implement hook_field_update().
*/
function location_cck_field_update($entity_type, $entity, $field, $instance, $langcode, &$items) {
  if (
$entity_type == 'node') {
    if (!empty(
$items)) {
     
// Store instances of locations by field name and vid.
     
$criteria = array(
       
'genid' => 'cck:' . $field['field_name'] . ':' . $entity->vid,
       
'vid' => $entity->vid,
       
'nid' => $entity->nid,
        
'uid' => $entity->uid,
      );
     
location_save_locations($items, $criteria);
    }
  }
  elseif (!empty(
$items)) {
    list(
$id, $vid, $bundle) = entity_extract_ids($entity_type, $entity);
   
// Store instances of locations by field name and vid.
   
$criteria = array(
     
'genid' => 'field:' . $field['field_name'] . ':' . $entity_type . ':' . $id,
     
'vid' => $vid ? $vid : $id,
     
'nid' => $id,
     
'uid' => $entity->uid,
    );
   
location_save_locations($items, $criteria);
  }
}
?>

Remember an update overwrites your changes unless this bug is not fixed.

Version:7.x-3.0-alpha8» 7.x-3.0-alpha9
Priority:Normal» Major
StatusFileSize
new9.32 KB
new18.42 KB

This issue affects my site as well. We're using views to display a report of users who match a given location field (Country, Province) and because uid is now being set to 0, the views query fails to pick up users

We started with location 7.x-3.0alpha1+1 which appears to write two entries per user in the location_instance table:

location7x30a1+1

After upgrading to location 7.x-3.0alpha6 (to resolve the Google location API error), only a single row is entered for the user:

location7x30a6

This problem extends to the current location7.x-3.0alpha9 (I have tested). The suggested workaround in this post fixes the issue, but only AFTER a user has updated their profile (obviously). Older entries are not picked up without manually updating the data by duplicating the vid > uid, then views can correctly fetch the data from the location table.

My views query looks like this (I added in the name field for context):

SELECT users.name AS users_name, users.uid AS uid, location.province AS location_province, location.country AS location_country, location.city AS location_city, location.postal_code AS location_postal_code, users.mail AS users_mail, users.created AS users_created
FROM
{users} users
LEFT JOIN {location_instance} location_instance ON users.uid = location_instance.uid
LEFT JOIN {location} location ON location_instance.lid = location.lid
ORDER BY users_created DESC
LIMIT 100 OFFSET 0

The base issue here is that uid is being written as 0 into location_instance, and views is looking to the uid column in location_instance to fetch the corresponding data from the location table.

Looking for thoughts on this issue.

Status:Active» Needs review
StatusFileSize
new1.58 KB
PASSED: [[SimpleTest]]: [MySQL] 425 pass(es).
[ View ]

rolled a patch adding 'uid' => $entity->uid for insert and update

(which creates a problem in location_chooser : Notice: Undefined index: title in location_chooser_form_node_form_alter() (line 163 of /var/www/caal-dev/sites/all/modules/location_chooser/location_chooser.module). I will check that module next)

/**
* Implement hook_field_insert().
*/
function location_cck_field_insert($entity_type, $entity, $field, $instance, $langcode, &$items) {
  if ($entity_type == 'node') {
    if (!empty($items)) {
      // Store instances of locations by field name and vid.
      $criteria = array(
        'genid' => 'cck:' . $field['field_name'] . ':' . $entity->vid,
        'vid' => $entity->vid,
        'nid' => $entity->nid,
        'uid' => $entity->uid,
      );
      location_save_locations($items, $criteria);
    }
  }
  elseif (!empty($items)) {
    list($id, $vid, $bundle) = entity_extract_ids($entity_type, $entity);
    // Store instances of locations by field name and vid.
    $criteria = array(
      'genid' => 'field:' . $field['field_name'] . ':' . $entity_type . ':' . $id,
      'vid' => $vid ? $vid : $id,
      'nid' => $id,
      'uid' => $entity->uid,
    );
    location_save_locations($items, $criteria);
  }
}
/**
* Implement hook_field_update().
*/
function location_cck_field_update($entity_type, $entity, $field, $instance, $langcode, &$items) {
  if ($entity_type == 'node') {
    if (!empty($items)) {
      // Store instances of locations by field name and vid.
      $criteria = array(
        'genid' => 'cck:' . $field['field_name'] . ':' . $entity->vid,
        'vid' => $entity->vid,
        'nid' => $entity->nid,
        'uid' => $entity->uid,
      );
      location_save_locations($items, $criteria);
    }
  }
  elseif (!empty($items)) {
    list($id, $vid, $bundle) = entity_extract_ids($entity_type, $entity);
    // Store instances of locations by field name and vid.
    $criteria = array(
      'genid' => 'field:' . $field['field_name'] . ':' . $entity_type . ':' . $id,
      'vid' => $vid ? $vid : $id,
      'nid' => $id,
      'uid' => $entity->uid,
    );
    location_save_locations($items, $criteria);
  }
}

Regarding

Older entries are not picked up without manually updating the data by duplicating the vid > uid

Why not write a SQL query that would update location_instance.uid = profile.uid WHERE location_instance.nid = profile.pid ?

I don't need it because I am building a new site, there isn't old data

W3Schools reference on SQL JOIN

Version:7.x-3.0-alpha9» 7.x-3.x-dev
Status:Needs review» Needs work

due to #3 this patch introduce new bug so please create follow up with bug fix or just fix introduced bug inside this one
Thanks!

I also submitted a patch for location_chooser fixing the bug in #3

#2051529: notice when looking for 'title' on profile2 node

it does not affect the patch submitted here, it popped up because of new data made available with the fix in #3 for Location

the patch in #3 has been tested, it should be good to go - or are you saying that the dev version has a new bug with this patch?

Issue summary:View changes

bad writing

Issue summary:View changes
StatusFileSize
new1.62 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch location_cck_location-instance-user-id.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

I did some research and came up with this patch. The problem with the patch in #3 is that it doesn't tackle the real problem. The problem is that $id and $vid get populated with the uid of the entity because of the entity_extract_ids() method.

I'm not sure if this is a solution that covers all bases, but it works in all tests I did, and I can't see anything else that would need to be covered.
Please review this and provide feedback.

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 7: location_cck_location-instance-user-id.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new993 bytes
PASSED: [[SimpleTest]]: [MySQL] 425 pass(es).
[ View ]

Disregard the patch in #7. I did not apply it to the dev version and did not follow the guidelines for patching.

With correcting this, I saw that most of the work I put in my patch was already done in the dev branch. However, the patch I include now should fix the last issue. the vid was still filled in, which is wrong when dealing with users and can lead to user addresses being retrieved if nodes have the same vid as a uid.

Status:Needs review» Fixed

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.