Default contents of email fields exceed maximum length code allows [#196402]

From within /admin/user/relationships/settings, I modified one option (not related to email) and then pressed Submit, to be presented with these errors:

    * Cancel relationship email subject cannot be longer than 128 characters but is currently 323 characters long.
    * Approve relationship email subject cannot be longer than 128 characters but is currently 395 characters long.
    * Disapprove relationship email subject cannot be longer than 128 characters but is currently 342 characters long.
    * Remove relationship email subject cannot be longer than 128 characters but is currently 329 characters long.

These are all default values from the install in these fields..

Comments

Comment #1

Coyote CreditAttribution: Coyote commented 7 December 2007 at 19:51

To fix this, I went into the file user_relationship_mailer.module and at around line 147, changed this

          $form['mail'][$op]["user_relationship_mailer_{$op}_subject"] = array(
            '#type'           => 'textfield',
            '#title'          => t('@Op relationship email subject', array('@Op' => ucfirst($op))),
            '#default_value'  => variable_get("user_relationship_mailer_{$op}_subject", $message_function()),
          );

to this:

          $form['mail'][$op]["user_relationship_mailer_{$op}_subject"] = array(
            '#type'           => 'textfield',
            '#maxlength'           => '512',
            '#title'          => t('@Op relationship email subject', array('@Op' => ucfirst($op))),
            '#default_value'  => variable_get("user_relationship_mailer_{$op}_subject", $message_function()),
          );

Although those default subject lines are pretty long... does anyone know if there's a limit on how long an e-mail subject line can be? Even if it's fairly high, it would be better for those default subjects to be more succinct.