Confirm forms to install & uninstall modules uses theme('item_list') inside.

Proposed
Convert module list to render array.

Changes in
system_modules_confirm_form()
- changed form item key 'text' => 'modules' (markup to #item_list)

system_modules_uninstall_confirm_form()
- split 'modules' key into prefix 'text' #markup and 'modules' #item_list

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

Status: Needs review » Needs work

The last submitted patch, 1964044-theme-list-1.patch, failed testing.

andypost’s picture

Status: Needs work » Needs review
FileSize
1.49 KB

theme missed # prefix

andypost’s picture

#3: 1964044-theme-list-3.patch queued for re-testing.

andypost’s picture

Issue tags: +Quick fix, +clean-up

taggin

h3rj4n’s picture

Status: Needs review » Reviewed & tested by the community

Applyed the patch. Removed a module and try to uninstall it. It shows the list as it should be.

Guess it still works as designed.

alexpott’s picture

The issue title and summary could be better...

This is not a great commit message...
git commit -m "Issue #1964044 by andypost: Confirm forms should provide render array."

andypost’s picture

FileSize
1.49 KB

Updated summary and re-rolled patch (list of modules now has 'modules' as element in form)

Suppose it needs changed notice because form structure changed

andypost’s picture

Title: Confirm forms should provide render array » Change module list in install/uninstall confirm form to render array

re-titled

webchick’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs issue summary update

Looks like good clean-up. Thanks for making the issue friendlier to the uninitiated. :)

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

update