Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Confirm forms to install & uninstall modules uses theme('item_list') inside.
Proposed
Convert module list to render array.
Changes in
system_modules_confirm_form()
- changed form item key 'text' => 'modules' (markup to #item_list)
system_modules_uninstall_confirm_form()
- split 'modules' key into prefix 'text' #markup and 'modules' #item_list
Comment | File | Size | Author |
---|---|---|---|
#8 | 1964044-theme-list-8.patch | 1.49 KB | andypost |
#3 | 1964044-theme-list-3.patch | 1.49 KB | andypost |
#1 | 1964044-theme-list-1.patch | 1.49 KB | andypost |
Comments
Comment #1
andypostThis changes was out of scope #1946454: Convert all confirm_form() in system.module and system.admin.inc to the new form interface and convert route
Comment #3
andyposttheme missed # prefix
Comment #4
andypost#3: 1964044-theme-list-3.patch queued for re-testing.
Comment #5
andyposttaggin
Comment #6
h3rj4n CreditAttribution: h3rj4n commentedApplyed the patch. Removed a module and try to uninstall it. It shows the list as it should be.
Guess it still works as designed.
Comment #7
alexpottThe issue title and summary could be better...
This is not a great commit message...
git commit -m "Issue #1964044 by andypost: Confirm forms should provide render array."
Comment #8
andypostUpdated summary and re-rolled patch (list of modules now has 'modules' as element in form)
Suppose it needs changed notice because form structure changed
Comment #9
andypostre-titled
Comment #10
webchickLooks like good clean-up. Thanks for making the issue friendlier to the uninitiated. :)
Committed and pushed to 8.x. Thanks!
Comment #11.0
(not verified) CreditAttribution: commentedupdate