Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Because this has evolved to more than just a file formatter, the current naming no longer reflects the true functionality of the module.
As a result, I'd suggest a name change (and move) to 'File Field Enhancements'.
Not only is this more accurate (and more likely to be found by someone looking for the file upload widget enhancements), it can also serve as a home for other enhancements we'd like to incorporate on drupal.org ... for example, merging in with http://drupal.org/project/files_undo_remove may be desirable.
Remaining tasks
Fix the project node at https://drupal.org/sandbox/jthorson/1964794Promote that sandbox to a full projectMove all the issues in this queue into the new project's queueMark this project node abandoned/obsolete#1954454: Use extended_file_field for issue node file fields for d.o D7 port
Comments
Comment #1
dww+1
Do you want to just create a new project node, and then push all the commits from here into the new Git repo, rename the module and all the files in that new repo, and then mark this project obsolete/abandoned? Or do you have another plan in mind? Lemme know how you want to proceed.
Thanks!
-Derek
Comment #2
dwwSanity check. We really want these:
?
Probably the best we're going to come up with, and we don't have unlimited time, but if we're going to go through the trouble to rename this, it'd be nice to only do it once. ;)
Cheers,
-Derek
Comment #3
jthorson CreditAttribution: jthorson commentedAgreed. Other options?
ff_enhanced
filefield_tweaks
ff_tweaks
filefield_improved
Comment #4
jthorson CreditAttribution: jthorson commentedTagging
Comment #5
dwwI prefer fieldfield over ff.
Maybe:
filefield_advanced
?
What about the modifier in front to further isolate us from possible namespace collisions with core? E.g.
advanced_filefield
extended_filefield
enhanced_filefield
?
Comment #6
dwwBased on further IRC discussion, I think we're converging on:
extended_file_field
Any final objections?
Thanks!
-Derek
Comment #7
dwwhttps://drupal.org/sandbox/jthorson/1964794 now exists.
I'm going to work on pushing these commits into there and renaming the module later today. If I don't get to this before I have to leave for the evening I'll unassign myself again.
Once there's working code and we fix the project description, we can promote that to full, move all the issues out of this queue, and mark this project obsolete/abandoned.
Thanks,
-Derek
Comment #8
dwwPushed the commits:
https://drupal.org/node/1964794/commits
Now I'll work on renaming everything.
Comment #9
dwwMostly went fine. A few lingering doubts:
hook_extended_file_field_metadata_types()
Do we still want think of this as the "metadata types" hook? I guess that's okay, even though metadata is no longer in the name of this module. It's still ultimately what the hook is about.
mymodule_extended_file_metadata_cid_formatter()
Is that a reasonable example name for this callback? Didn't seem like "mymodule_extended_file_field_metadata_cid_formatter()" was necessary, but it'd technically be more consistent that way.
There are a few Field API hooks that start with the word "field", so our module ending in the word "field" results in function names like:
etc. Slightly unfortunate, but I think it's fine.
Otherwise, this all seems to be working again on my local test site. I split it up into two commits to hopefully make it easier to follow WTF happened. The first is a pure 'git mv' on the 4 filenames:
http://drupalcode.org/sandbox/jthorson/1964794.git/commit/bdbd42d
The second is the actual code/docs changes:
http://drupalcode.org/sandbox/jthorson/1964794.git/commit/7096390
Once we resolve the above questions and get the project node happy, we can promote, move issues, fix up the d.o BZR tree, etc.
Thanks!
-Derek
Comment #10
jthorson CreditAttribution: jthorson commentedhook_extended_file_field_metadata_types()
The examples came from the first iteration of this code, where the sole purpose of the module was to add metadata to the table. Perhaps a change to 'hook_extended_file_field_columns()'?
mymodule_extended_file_metadata_cid_formatter()
As above, part of the first iteration ... I'd suggest 'mymodule_extended_file_field_cid_formatter()'.
Comment #11
dwwSplit the first off into a separate issue: #1964926: Rename hooks from "metadata" to "columns"
Agreed on the 2nd:
http://drupalcode.org/sandbox/jthorson/1964794.git/commit/5f7213a
Put remaining tasks in the summary.
Comment #12
jthorson CreditAttribution: jthorson commentedComment #12.0
jthorson CreditAttribution: jthorson commentedadded list of remaining tasks
Comment #13
jthorson CreditAttribution: jthorson commentedComment #14
dwwYay, thanks!
Comment #15
jthorson CreditAttribution: jthorson commentedComment #16.0
(not verified) CreditAttribution: commentedUpdated remaining tasks