Problem/Motivation
Varies issues in shortcut schema.
Proposed resolution
1. Fix schema to support all shortcut. i.e. changing shortcut.set.defult to shortcut.set.*
2. Add additional fields in active config to schema - missing links and status
Remaining tasks
#1 is fixed as part of #1964254: Configuration schemas missing langcode and uuid at places need to fix #2.
Comment | File | Size | Author |
---|---|---|---|
#14 | 1964588-shortcut-config-schema-14.patch | 571 bytes | vijaycs85 |
#14 | 1964588-diff-13-14.txt | 497 bytes | vijaycs85 |
#14 | 1964588-14.png | 22.88 KB | vijaycs85 |
#13 | 1964588-shortcut-config-schema-13.patch | 571 bytes | vijaycs85 |
#10 | 1964588-shortcut-config-schema-9.patch | 1.82 KB | vijaycs85 |
Comments
Comment #1
vijaycs85Fixing #2 here... #3 seems needs some code re-factoring which I will confirm with @alexpott or @Gabor before start.
Comment #2
vijaycs85minor issue in schema file.
Comment #3
Gábor HojtsyLet's have this postponed on #1964254: Configuration schemas missing langcode and uuid at places, since that is RTBC and heavily overlaps with this.
Comment #4
vijaycs85Comment #5
Gábor HojtsyAbove patch should not apply anymore due to #1964254: Configuration schemas missing langcode and uuid at places committed.
Comment #6
vijaycs85Re-rolling...
Comment #7
vijaycs85Adding screenshot for issue #3 in summary.
Comment #8
Gábor HojtsyLangcode is already there?! #1964254: Configuration schemas missing langcode and uuid at places already added langcode. Not status, but langcode it did :)
Comment #9
vijaycs85Thanks @Gábor Hojtsy. Removed duplicate langcode and added changes for #3 in summary. Links will be saved as array now.
UPDATE: locally throwing some error on adding new shortcut set. This needs more work...
Comment #10
vijaycs85Attaching patch for #9 :)
Comment #11
Gábor HojtsyDo we *need* to modify the format here so we can write a schema for it, or is just a choice we can make?
Comment #12
Gábor HojtsyIn other words, I'd avoid modifying the format if at all possible and just document it in this issue.
Comment #12.0
Gábor HojtsyUpdated issue summary.
Comment #13
vijaycs85Moving the format problem as a separate issue #1971456: Make usage of shortcut.settings.links consistent. This change doesn't affect schema, so this issue is not blocked :)
Comment #14
vijaycs85Attaching inspector form with minor label fix.
Comment #15
Gábor HojtsyLooks like all good, thanks.
Comment #17
vijaycs85#14: 1964588-shortcut-config-schema-14.patch queued for re-testing.
Comment #19
vijaycs85#14: 1964588-shortcut-config-schema-14.patch queued for re-testing.
Comment #20
Gábor HojtsyBack to RTBC as per #15. Test fails were unrelated.
Comment #21
webchickCommitted and pushed to 8.x. Thanks!
Comment #22
Gábor HojtsySuperb, thanks!
Comment #23.0
(not verified) CreditAttribution: commentedUpdated issue summary.