In case when entity bundle contains more than one 'office_hours' field the office_hours_feeds_set_target() assign wrong deltas for the second field on feed import (and any further office_hours field inside current entity).
This is because of condition that handles the value of $sv_index static var - the var value is reset to 0 in case when $entity->vid is changed. Need to introduce the same logic for the next office hour field inside the same entity.

Thanks in advance.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ruslan.muradov’s picture

Have scratched my head for a while and solved this problem. Here is the patch. Hope it will helps some one else :)

johnv’s picture

Status: Active » Needs review

Thanks for the patch.

johnv’s picture

Version: 7.x-1.1 » 7.x-1.x-dev
FileSize
1.22 KB

I've made a shorter version. Does it work for you?

Please download today's latest version first, and run update.php!

johnv’s picture

Title: Wrong deltas in 'office_hour' field on feeds import » On feeds import, wrong deltas when entity has multiple 'office_hours'-fields.

clearer title.

ruslan.muradov’s picture

>Does it work for you?
yes @johnv!

>Please download today's latest version first
The 7.x-dev bundle? Still shows to me that it is dated by 2013-Apr-06

johnv’s picture

Perhaps it needs some time to refresh. Try tomorrow. You can download from git, too.

johnv’s picture

Status: Needs review » Fixed

This is committed here
Thanks Ruslan.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Fixing the description