If i use entity translation module on a node and title is set(replaced) with title module then all titles will be same for all languages if i try to use automatic entity label module.

For example, if original node is in german and i would like to translate it to english(without creating new node) and submit the node, the title will be generated to english version and to german version too. Both of them will have the same title, in this case german version will have title of the english version. If i submit the form on german version then english version will have the german title. back and forth

CommentFileSizeAuthor
#13 auto_entity_lable-title_language-1965984-13.patch1.09 KBvincenzodb
#12 auto_entity_lable-title_language-1965984-12.patch896 bytesvincenzodb
#3 ael-entity-translation-bugfix-1965984-3.patch1.03 KBbforchhammer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bforchhammer’s picture

bforchhammer CreditAttribution: bforchhammer commented

Sounds like serious bug. This was working correctly when I wrote it initially; not sure what might have broken it, possibly a change in the title or ET module. I'll need to have a closer look before I can say more.

It would be good if we had a test case for the intended behavior...

mibfire’s picture

mibfire CreditAttribution: mibfire commented

I can add u access to my site where u can check this, just let me know.

bforchhammer’s picture

bforchhammer CreditAttribution: bforchhammer commented
Status: Active » Needs review
FileSize
ael-entity-translation-bugfix-1965984-3.patch1.03 KB

Entity translation changed the behavior of the entity_language() function, which caused the title module to sync the non-field title to the wrong language value. This means whenever you edited the translation of a node the original language title would be replaced by the translation language one...

Attached patch should fix the issue. @mibfire: can you apply the patch and see if that fixes it for you?

bforchhammer’s picture

bforchhammer CreditAttribution: bforchhammer commented
Status: Needs review » Fixed

I went ahead and commited #3. Feedback would still be appreciated :)

mibfire’s picture

mibfire CreditAttribution: mibfire commented

Thx fo the patch!!! I was very busy but will test it soon.

mibfire’s picture

mibfire CreditAttribution: mibfire commented

I tested and working well. THX once again!!!

bforchhammer’s picture

bforchhammer CreditAttribution: bforchhammer commented

Awesome, thanks for testing! :)

mibfire’s picture

mibfire CreditAttribution: mibfire commented

SHIT, i thought it was working but not it is not working:(((

mibfire’s picture

mibfire CreditAttribution: mibfire commented

bforchhammer? I sent u a mail, have u got?

mibfire’s picture

mibfire CreditAttribution: mibfire commented

It was my fault, sorry, the new patch is working well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

vincenzodb’s picture

vincenzodb CreditAttribution: vincenzodb as a volunteer commented
Issue summary: View changes
FileSize
auto_entity_lable-title_language-1965984-12.patch896 bytes

With
* core 7.53
* title - 1.0-alpha9
* auto_entity_label - dev
* entity_translation - 1.0-beta4

with this patch, on submit of a node translation (new or edit are the same), node's title will be replaced with the original language value and not with the custom title given by the token replacement of auto_entity_label.

We need to use the current form language

vincenzodb’s picture

vincenzodb CreditAttribution: vincenzodb as a volunteer commented
FileSize
auto_entity_lable-title_language-1965984-13.patch1.09 KB

Patch for dev