apachesolr_index_add_tags_to_document not getting the correct body text and not working as expected

It gets the text after it does the apachesolr_clean_text which removes the tags... This is bad behaviour. Fixing this asap

CommentFileSizeAuthor
#11 1966488-11.d6.patch8.37 KBmkalkbrenner
#7 1966488-5.patch8.6 KBpwolanin
#3 1966488-3.patch8.08 KBpwolanin
#3 1966488-test-only-3.patch5.27 KBpwolanin
#1 1966488-1.patch1.49 KBNick_vh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented
Status: Active » Needs review
FileSize
1966488-1.patch1.49 KB
pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

Looks like it has to be in the entity specific callback unless we add a way pass around the raw content?

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
FileSize
1966488-test-only-3.patch5.27 KB
1966488-3.patch8.08 KB

Here's a test-only patch + combined which also removes unused function apachesolr_add_tags_to_document()

Status: Needs review » Needs work

The last submitted patch, 1966488-test-only-3.patch, failed testing.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Status: Needs work » Needs review

ok, looks like the test case is detecting the bug.

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented
Priority: Normal » Major
pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
FileSize
1966488-5.patch8.6 KB

committed to 7.x this patch (also fixes README)

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

need to backport to 6.x-3.x

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

patch doesn't apply cleanly to 6.x, needs a little manual cleanup

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner commented
Assigned: Unassigned » mkalkbrenner
Issue summary: View changes
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner commented
Status: Patch (to be ported) » Needs review
FileSize
1966488-11.d6.patch8.37 KB

Backported to D6.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner commented
Status: Needs review » Fixed

  • Commit de2eff8 on 6.x-3.x by mkalkbrenner: 
    Issue #1966488 by Nick_vh, pwolanin, mkalkbrenner:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.