The module could use some tests to make sure that it works as designed.

CommentFileSizeAuthor
#16 simpletest-1966814-15.patch5.44 KBDelphine Lepers
#10 simpletest-1966814-10.patch5.44 KBangel.h
#9 1966814-9.patch5.42 KBiSoLate
#6 interdiff.txt1.26 KBpfrenssen
#6 1966814-6.patch5.42 KBpfrenssen
#1 1966814-1-scheduler_workbench-tests.patch5.58 KBpfrenssen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented
Status: Active » Needs review
FileSize
1966814-1-scheduler_workbench-tests.patch5.58 KB

Here are some initial tests.

Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented

I gave this patch one spin on simplytest.me and got 38 passes, 0 fails, 0 exceptions from the simpletest UI. Would it be a good idea to go enabling automated tests here for this project, have the bot process this patch, commit, move on with issues in the queue and continue to add test coverage?

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented

Enabling automatic testing would be very nice indeed.

To move this forward, this needs a code review, so it can be set to RTBC.

iSoLate’s picture

iSoLate CreditAttribution: iSoLate at Randstad Digital for Government of Flanders commented
Issue summary: View changes
iSoLate’s picture

iSoLate CreditAttribution: iSoLate at Randstad Digital for Government of Flanders commented
Status: Needs review » Needs work

The docblocks on the functions are wrong.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented
Status: Needs work » Needs review
FileSize
1966814-6.patch5.42 KB
interdiff.txt1.26 KB

Thanks for the review!

I've updated the documentation.

iSoLate’s picture

iSoLate CreditAttribution: iSoLate at Randstad Digital for Government of Flanders commented
Status: Needs review » Reviewed & tested by the community

better! :)

iSoLate’s picture

iSoLate CreditAttribution: iSoLate at Randstad Digital for Government of Flanders commented
Status: Reviewed & tested by the community » Needs work

Actually, with the latest update of scheduler, 'schedule (un)publishing of nodes' this permission no longer exists and is completely replaced by 'schedule publishing of nodes'. So this needs to be updated a bit.

iSoLate’s picture

iSoLate CreditAttribution: iSoLate at Randstad Digital for Government of Flanders commented
FileSize
1966814-9.patch5.42 KB

Updated patch.

angel.h’s picture

angel.h
Primary language English
Location Plovdiv
CreditAttribution: angel.h as a volunteer and commented
Status: Needs work » Needs review
FileSize
simpletest-1966814-10.patch5.44 KB

A few small coding standard fixes in the last patch. I think this is ready to go in.

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

I know it's been a while since anything was done here, but as there are currently no automated tests it would be good to get this committed. There are other issues whcih have patches, but they have nothing to test against.

Jonathan
(Scheduler module maintainer)

  • pfrenssen authored 46e8db3 on 7.x-1.x 
    Issue #1966814 by pfrenssen, iSoLate, angel.h: Write simpletests
Andrew M Riley’s picture

Andrew M Riley CreditAttribution: Andrew M Riley at Red Hat commented
Status: Reviewed & tested by the community » Fixed

Thank you. This has been committed.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented

Wow, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Delphine Lepers’s picture

Delphine Lepers CreditAttribution: Delphine Lepers for European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
simpletest-1966814-15.patch5.44 KB

The test "A published node with both dates in the future" fails for me.
The node is published, with a 'publish_on' date in the future.
When cron runs, nothing happens and the node is still published.
My mistake !

Delphine Lepers’s picture

Delphine Lepers CreditAttribution: Delphine Lepers for European Commission and European Union Institutions, Agencies and Bodies commented