API page: http://api.drupal.org/api/drupal/core%21modules%21user%21user.module/fun...

Enter a descriptive title (above) relating to function user_login_finalize, then describe the problem you have found:

> calls hook_user op 'login'

That doesn't exist any more! It's hook_user_login() now.

Files: 
CommentFileSizeAuthor
#10 fix-documentation-1966948-10.patch624 byteskiamlaluno
PASSED: [[SimpleTest]]: [MySQL] 54,375 pass(es).
[ View ]
#5 fix-documentation-1966948-5.patch623 byteskiamlaluno
PASSED: [[SimpleTest]]: [MySQL] 54,207 pass(es).
[ View ]
#3 fix-documentation-1966948-3.patch621 byteskiamlaluno
PASSED: [[SimpleTest]]: [MySQL] 54,468 pass(es).
[ View ]

Comments

OMG that is a really OLD reference (wrong in D7 as well). Thanks for the issue -- should be a good Novice project to fix... oh good you already tagged it. :)

Status:Active» Needs review
StatusFileSize
new621 bytes
PASSED: [[SimpleTest]]: [MySQL] 54,468 pass(es).
[ View ]

Status:Needs review» Needs work

+++ b/core/modules/user/user.module
@@ -1418,7 +1418,7 @@ function user_authenticate($name, $password) {
+ * login timestamp, calls hook_user_login and generates a new session.

AFAIK the name of the hook should get a () at the end so it's parsed into a link.

(Are you a novice? :p I'm sure I remember you from Drupalcon Copenhagen! :)

StatusFileSize
new623 bytes
PASSED: [[SimpleTest]]: [MySQL] 54,207 pass(es).
[ View ]

I used the same style used for the hook name in that Drupal 6 page. This is that patch that uses hook_user_login() for the hook name.

(I am a newbie; I started learning Drupal 3 months ago, and I am now trying to help with some Drupal patches. ;-))

Status:Needs work» Needs review

(I told you I am a newbie. ;-))

Status:Needs review» Needs work

There's no restriction that says "Only pure novices can patch issues tagged Novice". :)

Anyway, one more minor thing: in Drupal land we use the dreaded Oxford serial comma (so we need a comma before "and"). Other than that, looks fine to me, thanks!

I was only kidding :)

And yay for the Oxford comma!

Oh good that you were kidding -- in issue queue communication, sometimes it's hard to get tone of voice, body language, etc. from pure text. I wasn't quite sure and I would hate for anyone to think they weren't welcome to make any patch they'd like to make!!! :)

Status:Needs work» Needs review
StatusFileSize
new624 bytes
PASSED: [[SimpleTest]]: [MySQL] 54,375 pass(es).
[ View ]

Gee, I am surely less than a novice, with 3 tried patches. :-)

Assigned:Unassigned» jhodgdon
Status:Needs review» Reviewed & tested by the community

Thanks! That patch looks good and I'll get it committed shortly.

Assigned:jhodgdon» Unassigned
Status:Reviewed & tested by the community» Fixed

Thanks again! Committed to 8.x and 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.