password_policy keeps a history of all user password changes However, this when a user changes their password using the password reset link from this module, the password change is not recorded.

CommentFileSizeAuthor
#12 password_policy-7.x-2.x-use_presave_for_history-1967940-12.patch2.61 KBAohRveTPV
#11 password_policy-7.x-2.x-use_presave_for_history-1967940-11.patch2.64 KBAohRveTPV
#10 password_policy-7.x-2.x-use_presave_for_history-1967940-10.patch2.69 KBAohRveTPV
#7 password_policy-7.x-1.x-use_presave_for_history-1967940-7.patch3.74 KBAohRveTPV
#6 password_hussle-password-policy-support-1967940-6.patch696 byteshanoii
#1 1967940-password_hussle_password-policy.patch555 bytesmrfelton
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mrfelton’s picture

mrfelton CreditAttribution: mrfelton commented
Status: Active » Needs review
FileSize
1967940-password_hussle_password-policy.patch555 bytes

This is all thats needed.

Status: Needs review » Needs work

The last submitted patch, 1967940-password_hussle_password-policy.patch, failed testing.

SolomonGifford’s picture

SolomonGifford CreditAttribution: SolomonGifford commented
Status: Needs work » Postponed (maintainer needs more info)

Is there a reason not to do this with hook_user_presave in the password_policy‎ module?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Title: Integrate with password_policy module (record password change history) » Use hook_user_presave in password_policy to be compatible with more modules
Project: Password Hustle » Password Policy
Version: 7.x-1.0 » 7.x-2.x-dev
Status: Postponed (maintainer needs more info) » Active

Moving to a better place to discuss the proposal in #3.

erikwebb’s picture

erikwebb CreditAttribution: erikwebb commented

That makes sense to me. You have my blessing.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
CreditAttribution: hanoii commented
Issue summary: View changes
FileSize
password_hussle-password-policy-support-1967940-6.patch696 bytes

I had the necessity ro re-roll the original patch for password_hustle for the time being, so leaving here for reference, but any follow up on using presave on password policy?

AohRveTPV’s picture

AohRveTPV CreditAttribution: AohRveTPV commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
Status: Active » Needs review
FileSize
password_policy-7.x-1.x-use_presave_for_history-1967940-7.patch3.74 KB

New features go into 7.x-2.x first, but here is a 7.x-1.x patch for review/testing.

AohRveTPV’s picture

AohRveTPV CreditAttribution: AohRveTPV commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs review » Active
AohRveTPV’s picture

AohRveTPV CreditAttribution: AohRveTPV commented

Discovered bug in 7.x-1.x when porting #7 to 7.x-2.x:
#2462647: Two password history entries created for new users, one invalid

AohRveTPV’s picture

AohRveTPV CreditAttribution: AohRveTPV commented
Status: Active » Needs review
FileSize
password_policy-7.x-2.x-use_presave_for_history-1967940-10.patch2.69 KB

Please review/test.

AohRveTPV’s picture

AohRveTPV CreditAttribution: AohRveTPV commented
FileSize
password_policy-7.x-2.x-use_presave_for_history-1967940-11.patch2.64 KB

Simplify conditions in hook_user_presave().

AohRveTPV’s picture

AohRveTPV CreditAttribution: AohRveTPV commented
FileSize
password_policy-7.x-2.x-use_presave_for_history-1967940-12.patch2.61 KB

Update to apply on latest code.

AohRveTPV’s picture

AohRveTPV CreditAttribution: AohRveTPV commented

I am committing #12 without review for the sake of testing. We already switched to hook_user_presave() in 7.x-1.x to fix #2462647: Two password history entries created for new users, one invalid. By committing the same change to 7.x-2.x, we can get some testing of this change in an alpha release before making a full release of the change in 7.x-1.x.

Would still be glad for any review/testing of this change.

  • AohRveTPV committed 7a40f65 on 7.x-2.x 
    Issue #1967940 by AohRveTPV, mrfelton, hanoii: Use hook_user_presave in...
AohRveTPV’s picture

AohRveTPV CreditAttribution: AohRveTPV commented
Version: 7.x-2.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)
AohRveTPV’s picture

AohRveTPV CreditAttribution: AohRveTPV commented
Status: Patch (to be ported) » Closed (outdated)

6.x-1.x is no longer supported.