Replace field_info_fields() with field_info_field_map() for Drupal >= 7.22 [#1968828]

There's one field_info_fields() in the date_repeat_field() module which runs in a menu access callback, which I think means it's called on every page request. I've attached a patch so that the new field_info_field_map() can be used in Drupal >= 7.22.

There are two other field_info_fields() calls which do not run on every page request. Both of them are quickly followed by loops which require field info for every field, so it's probably valid usage.

Context
From Drupal 7.22, there is the field_info_field_map() function that is more lightweight. If no modules use field_info_fields() during a page request then performance benefits are likely. Change record: The Field API's memory usage has been optimized (includes recommended changes to contributed modules to leverage the changes). New documentation for field_info_fields(): http://api.drupal.org/api/drupal/modules%21field%21field.info.inc/functi...

Comment	File	Size	Author
#4	date_repeat_field-1968828-4.patch	2.05 KB	pjcdawkins
#4
#2	date_repeat_field-1968828-2.patch	2 KB	pjcdawkins
#2
	date_repeat_field_memory.patch	1.3 KB	pjcdawkins

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #0.0

pjcdawkins CreditAttribution: pjcdawkins commented 12 April 2013 at 15:24

Issue summary:

View changes

Clarified.

Comment #0.1

pjcdawkins CreditAttribution: pjcdawkins commented 12 April 2013 at 15:25

Issue summary:

View changes

minor fix

Comment #1

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 12 December 2013 at 21:21

Issue summary:	View changes
Status:	Needs review	» Needs work

+++ b/date_repeat_field/date_repeat_field.module
@@ -119,12 +119,15 @@ function date_repeat_field_permission() {
+  $field_map = VERSION >= '7.22' ? field_info_field_map() : field_info_fields();

You need to use version_compare to compare these strings. A simple greater than operator is not the proper thing to use.

Comment #2

pjcdawkins CreditAttribution: pjcdawkins commented 13 December 2013 at 16:29

Status:

Needs work

» Needs review

File	Size
date_repeat_field-1968828-2.patch	2 KB

1 file was hidden/shown/deleted

File	Size
date_repeat_field_memory.patch	1.3 KB

Right, and my first patch looks really wrong. Here's a second attempt, with the addition of a function comment (because the original comment didn't seem to reflect what the function actually does).