The current design (as well as the 7.x-1.x branch for a different reason) isn't compatible with the Coder Review module. The Coder Review module adds a operation link to each module to do a Coder check for that module.

The problem is at theme_module_filter_operations() has a pre-defined list of operations that it will convert to the drop down button, so any links that another module adds (like Coder Review) are dropped.

CommentFileSizeAuthor
#11 module_filter-incompatibility-with-Tab-mode-and-Coder-Review-module-1969856-11.patch644 bytesiStryker
#6 module_filter-incompatibility-with-Tab-mode-and-Coder-Review-module-1969856-comment-6.patch1 KBossguys
#5 module_filter-incompatibility-with-Tab-mode-and-Coder-Review-module-1969856-comment-2.patch1.01 KBcamoa
#4 module_filter-ncompatibility-with-Tab-mode-and-Coder-Review-module-1969856-comment#2.patch1.01 KBcamoa
#1 module_filter-ncompatibility-with-Tab-mode-and-Coder-Review-module-1969856-comment#2.patch1.01 KBcamoa
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

camoa’s picture

camoa CreditAttribution: camoa commented
FileSize
module_filter-ncompatibility-with-Tab-mode-and-Coder-Review-module-1969856-comment#2.patch1.01 KB

Hello, I have been checking this on branches 7.x-1.x and 7.x-2.x.
Basically the reason is the same in both, module filter has the links hard coded (help, configure, permissions) I changed branch 7.x-2.x and fixed the issue, I hope I did it right I would love to have some feedback. I am working on 7.x-1.x since the way they handle the links array there is different.

Thanks

camoa’s picture

camoa CreditAttribution: camoa commented
Status: Active » Needs review

I would like to know your opinions on the patch sent before. Thanks

ossguys’s picture

ossguys CreditAttribution: ossguys commented
Status: Needs review » Needs work

Patch file doesn't seem to be opening. Can you please re-attach the file?

camoa’s picture

camoa CreditAttribution: camoa commented
FileSize
module_filter-ncompatibility-with-Tab-mode-and-Coder-Review-module-1969856-comment#2.patch1.01 KB

I tried, it is rejecting the file.....

camoa’s picture

camoa CreditAttribution: camoa commented
FileSize
module_filter-incompatibility-with-Tab-mode-and-Coder-Review-module-1969856-comment-2.patch1.01 KB

Another attempt.

Done, problem with the name.

ossguys’s picture

ossguys CreditAttribution: ossguys commented
Status: Needs work » Reviewed & tested by the community
FileSize
module_filter-incompatibility-with-Tab-mode-and-Coder-Review-module-1969856-comment-6.patch1 KB

@camoatech - The patch solved the problem!

Although there were following minor issues while applying the patch so I have corrected the patch and attached here. It's just related to trailing whitespaces and minor space issue.

root:# git apply -v module_filter-incompatibility-with-Tab-mode-and-Coder-Review-module-1969856-comment-2.patch
module_filter-incompatibility-with-Tab-mode-and-Coder-Review-module-1969856-comment-2.patch:25: trailing whitespace.

module_filter-incompatibility-with-Tab-mode-and-Coder-Review-module-1969856-comment-2.patch:30: trailing whitespace.
}
Checking patch module_filter.theme.inc...
Applied patch module_filter.theme.inc cleanly.
warning: 2 lines add whitespace errors.

camoa’s picture

camoa CreditAttribution: camoa commented

Thanks for the fix!

drupalshrek’s picture

drupalshrek CreditAttribution: drupalshrek commented
Issue summary: View changes

I'm having this issue: with Module Filter switched on, the Code Review link does not appear.

I am using the latest version of module filter. Is the above patch applied there yet?

camoa’s picture

camoa CreditAttribution: camoa commented

I don't believe so... but you can apply it to version 2.

drupalshrek’s picture

drupalshrek CreditAttribution: drupalshrek commented

Applying patches is not in my experience, so I just disabled the Module Filter module.

iStryker’s picture

iStryker CreditAttribution: iStryker commented
FileSize
module_filter-incompatibility-with-Tab-mode-and-Coder-Review-module-1969856-11.patch644 bytes

Cannot apply patch to master as it conflicts with the commit of #2304687: Remove hardcoded operations.

If #2304687 is not applied then there is a huge amount of theming errors.

Attached is patch against master +5

greenSkin’s picture

greenSkin CreditAttribution: greenSkin commented
Status: Reviewed & tested by the community » Closed (cannot reproduce)

I've installed Coder Review (version 2.4) and I do not see the issue. The "Code review" link renders as expected whether using dropbutton or not, no patch needed. Is this an issue with the 1.2 release of the Coder module?