Problem with multiselect when list is generated by views

Hello,
I post my patch here because your problem was also mine but with entity reference generated by views. My patch also resolve an Notice : Undefined index: nid and makes multiselect language aware.

Try it and tell me if everything all right.

I changed the title a bit and the module version. Feel free to modify it again if I'm wrong.

+++ b/multiselect.module
@@ -76,6 +76,9 @@ function multiselect_field_widget_form(&$form, &$form_state, $field, $instance,
+  //not used but you never know :-)
+  $handler = $field['settings']['handler'];

Do not add code clutter for no reason please.

+++ b/multiselect.module
@@ -86,18 +89,22 @@ function multiselect_field_widget_form(&$form, &$form_state, $field, $instance,
+  //Remove all tags from values. Very useful for views displays.

What is the issue with views displays? Does this still allow me to have options like "<Yes>" and "<No>"?

+++ b/multiselect.module
@@ -86,18 +89,22 @@ function multiselect_field_widget_form(&$form, &$form_state, $field, $instance,
+  ¶

Trailing whitespace.

+++ b/multiselect.module
@@ -138,8 +145,8 @@ function _multiselect_after_build($element, $form_state) {
+    foreach ($form_state['values'][$element['#field_name']][$element['#language']] as $nid) {

Good one, but is $element['#language'] guaranteed by spec to be always set?

I am currently trying out jquery_ui_multiselect so I'm not able to do much testing on this one.

Thank you for your report.

1. Sorry for the useless code. I first thought that to handle the <tags /> issue with views, I had to do some "if" statement with the $handler... I removed it.
2. The issue with views is shown by screenshot #3 as exposed by knowledges33ker. Views adds spans when displaying items in a select. And sorry but your comment was truncated and I don't know what you meant by
   

   options like "" and ""

3. White space removed
4. For the language, my first thought was to use the global $language. But the global var can be different from the #element['language']. So to guarantee that it will be always set I've added some if statement.

Here's my patch modified.

Thanks for making these patches, anou! It is incredibly helpful for me. I just applied your patches, which made me realize one big issue for anyone trying to test your patch, you rolled your newest patch against your customized version of the module rather than the dev version of the module. In order to make this work, I had to apply the first patch, and then apply the second patch. Could you re-roll the patch so that testers can just use the most recent one? I'll be testing this in the coming weeks some more to see how it holds up.

Hello Robby,
here's a new patch with all my modifications in one place. I think it's ok... please let me know if it's what you want it. Thanks.

I had the nid issue. The patch works perfectly. Thanks!

The Patch in #6 worked for me as well. Just be sure you apply it to DEV version. Might be ready for a new version??

Thanks for this module.

Neil

I just added this to the development version.