Follow up for #1964648: Create configuration schemas for editor module
Problem/Motivation
*.schema.yml files has different label("Langcode", "Language", "Default language".) for 'langcode' field.
Proposed resolution
We can stick with 'Language' where we can't be changed and 'Default language' where we can.
Remaining tasks
Update all schema files once all schemas are in. Can check http://drupal.org/project/issues/search/drupal?status%5B%5D=1&status%5B%...
Original report by @Wim Leers
Comment | File | Size | Author |
---|---|---|---|
#17 | 1971490-3.patch | 3.07 KB | balagan |
#7 | 1971490-2.patch | 2.66 KB | balagan |
Comments
Comment #1
Wim LeersTypo fix :)
Comment #2
Wim LeersThis is not specific to editor.module, it really is a CMI module. Best-effort recategorization.
Comment #3
alexpottComment #4
balagan CreditAttribution: balagan commentedI already cannot find any label: 'Langcode' occurances, carrying on checking label: 'Language'
Comment #5
balagan CreditAttribution: balagan commentedThere was only one occurance that I could find on the UI, I have changed that to 'Default language'.
Comment #6
balagan CreditAttribution: balagan commentedComment #7
balagan CreditAttribution: balagan commentedI have just realized that I have changed a wrong entry (not a langcode). Now I have changed all the other occurances to Default language. Also did a search for 'Language code', there was only 1 of it.
Comment #9
Gábor Hojtsy7: 1971490-2.patch queued for re-testing.
Comment #11
balagan CreditAttribution: balagan commented7: 1971490-2.patch queued for re-testing.
Comment #12
YesCT CreditAttribution: YesCT commentedI think we made an effort to have the label in the schemas to match what the UI labels are.
I'm not sure we should now change the schemas... without also standardizing what the UI has.
Comment #13
Gábor HojtsyComment #14
YesCT CreditAttribution: YesCT commentedI agree. If these are ones that never show in the UI, then making them consistent is a very good idea.
Comment #15
vijaycs85looks good to me, but we might not covered all schema files.
Comment #16
balagan CreditAttribution: balagan commentedI check it again
Comment #17
balagan CreditAttribution: balagan commentedSorry, I have missed the block.schema.yml file. Enclosed a new patch.
Now there should not be any more *schema.yml file with label: 'language', label: 'language code' and label: 'langcode' strings, all were changed to label: 'Default language'
Comment #18
Gábor HojtsyLooks good as per above :)
Comment #19
vijaycs85just doubled checked all schema files and seems the patch in #17 covering all of them (we got 26 instance except those 7 in patch, all of them already got 'Default language'). So +1 for RTBC.
Comment #20
webchickNice clean-up.
Committed and pushed to 8.x. Thanks!