Follow up for #1953404: Add config schema to field and instance config entities

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. As a part of schema addition to field module(#1953404: Add config schema to field and instance config entities), found that we have to provide schema for field types, field widgets and field storage.

Proposed solution

Create a configuration schema for field types, field widget and field storage (if applicable) defined in datetime module.
Schema in place

Schema not yet in place
field.datetime.settings
field.datetime.instance_settings
field.datetime.value

field_widget.datetime_default.value
field_widget.datetime_datelist.value

Files: 
CommentFileSizeAuthor
#10 dattime_schema-1973534-10.patch542 bytesyched
PASSED: [[SimpleTest]]: [MySQL] 59,376 pass(es).
[ View ]
#7 Screen Shot 2013-12-08 at 17.48.51.png56.31 KBvijaycs85
#6 1973534-diff-3-6.txt517 bytesvijaycs85
#6 1973534-config-schema-filed-datetime-6.patch942 bytesvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 59,317 pass(es).
[ View ]
#3 1973534-config-schema-filed-datetime-3.patch843 bytespiyuesh23
PASSED: [[SimpleTest]]: [MySQL] 56,439 pass(es).
[ View ]
#1 1973534-config-schema-filed-datetime-1.patch1.41 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 54,613 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new1.41 KB
PASSED: [[SimpleTest]]: [MySQL] 54,613 pass(es).
[ View ]

Initial patch...

Title:Provide config schema to field types, widgets and storage in datetime moduleProvide config schema to field types and storage in datetime module
Status:Needs review» Needs work

Widget needs to go out after #1875992: Add EntityFormDisplay objects for entity forms got in.

StatusFileSize
new843 bytes
PASSED: [[SimpleTest]]: [MySQL] 56,439 pass(es).
[ View ]

Removed the widget from the schema file. Attaching the patch.

Status:Needs work» Needs review

Status:Needs review» Needs work

Default value isn't a string. When I inspect it with the config inspector it tries to add an array in the default value. Which doesn't work. So this probably needs a special mapping.

Issue summary:View changes
Status:Needs work» Needs review
Issue tags:+LONDON_2013_DECEMBER
StatusFileSize
new942 bytes
PASSED: [[SimpleTest]]: [MySQL] 59,317 pass(es).
[ View ]
new517 bytes

Thanks for the test @aspilicious. Fixed and tested with config_inspector.

StatusFileSize
new56.31 KB

Adding config inspector screenshot...

Status:Needs review» Reviewed & tested by the community

Thnx! :)

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Status:Fixed» Needs review
StatusFileSize
new542 bytes
PASSED: [[SimpleTest]]: [MySQL] 59,376 pass(es).
[ View ]

Quick followup: the user_register_form setting is long gone now :-)

Status:Needs review» Fixed

Never mind, we'll fix this as part of #1989468: Weird messing with 'default_value_function' in date widgets ?.
Sorry for the noise.

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.