Problem/Motivation

Since we have already #80855: Add element #type table and merge tableselect/tabledrag into it and we are #1876712: [meta] Convert all tables in core to new #type 'table' and after that will #1876714: Remove #type 'tableselect', we need to build out our table rendering tests.

Proposed resolution

Build on our tests in Drupal\system\Tests\Theme\TableTest to include tableselect/tabledrag coverage in tests for #type table.

Remaining tasks

See Proposed Resolution.

User interface changes

None.

API changes

None.

Several of http://drupal.org/project/issues/search?text=table&projects=&status[]=Open, specifically:
#1876712: [meta] Convert all tables in core to new #type 'table'
#1876714: Remove #type 'tableselect'
#1876718: Allow modules to inject columns into tables more easily

CommentFileSizeAuthor
#16 interdiff.txt1.46 KBNitesh Pawar
#16 expand_render_test-1975152-16.patch2.6 KBNitesh Pawar
#12 expand_render_test-1975152-12.patch2.66 KBNitesh Pawar
#9 expand_render_test-1975152-9.patch2.63 KBjoelpittet
#6 drupal-type-table-render-tests--1975152-5.patch2.86 KBsteveoliver
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

steveoliver’s picture

steveoliver CreditAttribution: steveoliver commented
Title: Expand test coverage #type table » Expand render test coverage for #type table
Issue tags: +Needs tests

title, tag

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

Core 8 introduced some new elements and it would be good to collect em in Drupal\system\Tests\Common\RenderTest

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Priority: Normal » Major

Hm. I think given there are at least 3-4 issues that are changing this stuff and punting on test coverage, we should escalate this a bit.

steveoliver’s picture

steveoliver CreditAttribution: steveoliver commented
Assigned: Unassigned » steveoliver
steveoliver’s picture

steveoliver CreditAttribution: steveoliver commented

Update: I'm making progress here. I haven't forgotten, just lagging.

steveoliver’s picture

steveoliver CreditAttribution: steveoliver commented
Assigned: steveoliver » Unassigned
FileSize
drupal-type-table-render-tests--1975152-5.patch2.86 KB

Not much here so far, but I gotta unassign to get back to Twig review/profiling...

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Issue summary: View changes
Status: Active » Needs work

Changing status since there is a start here.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented 
  1. +++ b/core/modules/system/lib/Drupal/system/Tests/Render/TypeTableTest.php
@@ -0,0 +1,68 @@
+    $this->assertRaw('<tr class="odd"><td>Foo</td><td>Bar</td><td>Baz</td> </tr>', 'Table row rendered from #rows property.');
...
+    $this->assertRaw('<tr class="odd"><td>Foo</td><td>Bar</td><td>Baz</td> </tr>', 'Table row rendered from child render elements.');
...
+    $this->assertRaw('<tr class="draggable odd"><td>Foo 1</td><td>Bar 1</td><td>Baz 1</td><td></td> </tr>\n <tr class="draggable even"><td>Foo 2</td><td>Bar 2</td><td>Baz 2</td> </tr>', 'Table row rendered with tabledrag from child render elements.');

    xpath may be better to avoid having to keep track of whitespace changes? 

  2. +++ b/core/modules/system/lib/Drupal/system/Tests/Theme/TableTest.php
@@ -16,7 +16,7 @@ class TableTest extends WebTestBase {
-      'description' => 'Tests built-in theme functions.',
+      'description' => 'Tests built-in table theme functions.',

    Probably can be 'table templates'?

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Needs work » Needs review
Issue tags: -Needs tests +rc eligible
FileSize
expand_render_test-1975152-9.patch2.63 KB

Re-roll and see what test bot thinks.

Status: Needs review » Needs work

The last submitted patch, 9: expand_render_test-1975152-9.patch, failed testing.

The last submitted patch, 9: expand_render_test-1975152-9.patch, failed testing.

Nitesh Pawar’s picture

Nitesh Pawar CreditAttribution: Nitesh Pawar at Trigyn Technologies Ltd commented
Status: Needs work » Needs review
FileSize
expand_render_test-1975152-12.patch2.66 KB

Patch on new revision

Status: Needs review » Needs work

The last submitted patch, 12: expand_render_test-1975152-12.patch, failed testing.

The last submitted patch, 12: expand_render_test-1975152-12.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett as a volunteer commented 
  1. +++ b/core/modules/system/src/Tests/Render/TypeTableTest.php
@@ -0,0 +1,68 @@
+ * Functional tests for #type table.
+ */
+class TypeTableTest extends WebTestBase {
+  public static function getInfo() {
+    return array(
+      'name' => 'Type Table',
+      'description' => "Tests #type 'table' render functions.",
+      'group' => 'Render',
+    );
+  }

    getInfo is obsolete, you need a @group annotation on the test class 

  2. +++ b/core/modules/system/src/Tests/Render/TypeTableTest.php
@@ -0,0 +1,68 @@
+  function testRenderTableFromRows() {
...
+  function testRenderTableFromChildren() {
...
+  function testRenderTableWithTabledrag() {
...
+  function testRenderTableWithTableselect() {

    These should be public 

  3. +++ b/core/modules/system/src/Tests/Render/TypeTableTest.php
@@ -0,0 +1,68 @@
+  function testRenderTableWithTableselect() {
+
+  }

    This can't be empty

Nitesh Pawar’s picture

Nitesh Pawar CreditAttribution: Nitesh Pawar at Trigyn Technologies Ltd commented
Status: Needs work » Needs review
FileSize
expand_render_test-1975152-16.patch2.6 KB
interdiff.txt1.46 KB

Thanks @tim.plunkett changes done as you suggested.

Status: Needs review » Needs work

The last submitted patch, 16: expand_render_test-1975152-16.patch, failed testing.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented 
+++ b/core/modules/system/src/Tests/Render/TypeTableTest.php
@@ -0,0 +1,64 @@
+    $this->content = drupal_render($table);
+    $this->assertRaw('<tr class="odd"><td>Foo</td><td>Bar</td><td>Baz</td> </tr>', 'Table row rendered from #rows property.');

This may be ripe for using $this->removeWhiteSpace(); Just a guess. And maybe render_render() can be just Drupal::service('renderer')->renderPlain() to avoid testing asset attachment stuff.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.