Collapse has a feature detection script that is now in modernizr (we didn't have modernizr when the details patch was committed).

It fixes the script dependencies and adds the global Modernizr object to the jshint configuration.

There were issues with the details styling and the use of jQuery .prop to deal with the open attribute. (makes the whole thing behave strangely, try the module page on firefox).

CommentFileSizeAuthor
#7 core-js-clean-collapse-1975426-7.patch4.31 KBnod_
#2 core-js-clean-collapse-1975426-2.patch4.06 KBnod_
core-js-clean-collapse.patch3.51 KBnod_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Issue tags: +mobile, +JavaScript clean-up

tag

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
FileSize
core-js-clean-collapse-1975426-2.patch4.06 KB

reroll after #1976964: Add Modernizr to the .jshintrc file

Status: Needs review » Needs work
Issue tags: -mobile, -JavaScript clean-up

The last submitted patch, core-js-clean-collapse-1975426-2.patch, failed testing.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs work » Needs review
Issue tags: +mobile, +JavaScript clean-up

#2: core-js-clean-collapse-1975426-2.patch queued for re-testing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs review » Reviewed & tested by the community

Manually tested in Chrome and Firefox (which doesn't support <details>), on the modules page and at node/1/edit. Works as advertised.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

if we are truly cleaning up collapse.js let's fix this too...

$ jshint --verbose --show-non-errors core/misc/collapse.js
core/misc/collapse.js :
	Unused Variables:
		$link(69),
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs work » Needs review
FileSize
core-js-clean-collapse-1975426-7.patch4.31 KB

:D

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs review » Reviewed & tested by the community

:)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 3b5fd77 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.