Files: 
CommentFileSizeAuthor
#3 custom-block-add-1978168.6.interdiff.txt1.4 KBlarowlan
#3 custom-block-add-1978168.6.patch5.91 KBlarowlan
PASSED: [[SimpleTest]]: [MySQL] 55,887 pass(es).
[ View ]
#1 custom-block-add-1978168.1.patch6.1 KBlarowlan
PASSED: [[SimpleTest]]: [MySQL] 55,814 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new6.1 KB
PASSED: [[SimpleTest]]: [MySQL] 55,814 pass(es).
[ View ]

Looks pretty good. Some nitpicks:

+++ b/core/modules/block/custom_block/lib/Drupal/custom_block/Controller/CustomBlockController.phpundefined
@@ -0,0 +1,101 @@
+  /**
+   * Injects Request and Entity Manager Service.
+   *
+   * @param \Symfony\Component\DependencyInjection\ContainerInterface $container
+   *   The DI container.
+   */

{@inheritdoc}

+++ b/core/modules/block/custom_block/lib/Drupal/custom_block/Controller/CustomBlockController.phpundefined
@@ -0,0 +1,101 @@
+   * Page callback: Displays add custom block links for available types.

No Page Callback:

+++ b/core/modules/block/custom_block/lib/Drupal/custom_block/Controller/CustomBlockController.phpundefined
@@ -0,0 +1,101 @@
+   * @see custom_block_menu()

this should be removed

StatusFileSize
new5.91 KB
PASSED: [[SimpleTest]]: [MySQL] 55,887 pass(es).
[ View ]
new1.4 KB

Fixes issues from #2

Status:Needs review» Reviewed & tested by the community

looks awesome, thanks! it will be perfect once the issue above is in :)

Status:Reviewed & tested by the community» Fixed

Committed 7449317 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.