Streamlined 7.x-2.x branch [#1978320]

I've created a streamlined 7.x-2.x branch. This new branch:

- Uses the new async tracking code, and provides a template so you can change it if you like.
- Gets rid of huge piles of crappy non functional code which I imagine were left over from a hasty port to D7.
- Makes use of tools available in D7 like renderable arrays to reduce the amount of code required and provide more flexibility.
- Removes the extra code for the affiliate blocks, it's easy enough to add yourself, I don't think this module should add the cruft.

git diff --stat 7.x-1.x 7.x-2.x
3 files changed, 111 insertions(+), 194 deletions(-)

I've attached it as a patch and a tar.gz.

Comment	File	Size	Author
#1	getclicky-7x-2x.patch	227 bytes	aidanlis
#1	getclicky-7x-2x.tgz	89.44 KB	aidanlis
	getclicky-7x-2x.patch	15.08 KB	aidanlis
	getclicky7x-2x.tar_.gz	88.01 KB	aidanlis

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

aidanlis CreditAttribution: aidanlis commented 24 April 2013 at 06:36

File	Size
getclicky-7x-2x.tgz	89.44 KB
getclicky-7x-2x.patch	227 bytes

Slight tweak attached. Also the .tgz has a .git repository in it, so if you're going to commit please merge that in.

47edf6566e9b7990ef83c57d9f792ca097ef8445 Mistakenly used "arguments" instead of "variables" in hook_theme.
3f2a7b77601da9b8b364a6e65422e66ba9cee38d Remove the long winded description and affiliate link from configuration page -- there's no original code left after this rewrite so I think it's fair to remove. Tweak the admin page to be less dependent on garland.
df8baaeeb9edd0b810eab729a501ac5f51d40f91 Rewrite to use a renderable array, with the access check done in #access. Move the actual JS code into a tpl.php for easy customisation and add hook_theme accordingly. Use drupal_match_path to check for admin pages. Basically, rewrite all the code so it doesn't suck.
7cd0dc7f0f9aa54d3a6ff80802942d0ca50a9f70 Clean up the admin page -- reshuffle the options around and get rid of the cruft.
8d281250470dafb01e8a8fb120f47ef92db346df Strip out the banner code. If people want to add a banner, they can create a block themselves, I don't think this module provides any benefit by proving this itself and it just adds cruft to the code.
6899cfbaaaaeaea727c96b33ad2f79f8636cd33f Add a description for the username tracking
23d414004a09df9b2701a9211ca3a6f5e8b28480 Remove unused $roles query

Comment #2

ctrnz CreditAttribution: ctrnz commented 26 April 2014 at 07:04

I just wanted to say: thank You very much for this branch!

Comment #3

rsvelko CreditAttribution: rsvelko commented 26 April 2014 at 20:07

Issue summary:

View changes

will be looked into right away and commited asap!

Comment #4

22 November 2014 at 15:41

rsvelko committed 8a28892 on 7.x-1.x

Issue #1978320 by aidanlis, rsvelko: Streamlined 7.x-2.x branch - Remove...

Comment #5

rsvelko CreditAttribution: rsvelko commented 22 November 2014 at 15:43

list of commits in this new 2.x repo:

1 47edf65 Mistakenly used "arguments" instead of "variables" in hook_theme.
2 3f2a7b7 Remove the long winded description and affiliate link from configuration page -- there's no original code left after this rewrite so I think it's fair to remov
3 df8baae Rewrite to use a renderable array, with the access check done in #access. Move the actual JS code into a tpl.php for easy customisation and add hook_theme acco
4 7cd0dc7 Clean up the admin page -- reshuffle the options around and get rid of the cruft.
5 8d28125 Strip out the banner code. If people want to add a banner, they can create a block themselves, I don't think this module provides any benefit by proving this i
6 6899cfb Add a description for the username tracking
7 23d4140 Remove unused $roles query

I've commited last one 23d4140 to 7.x-1.x

Comment #6

22 November 2014 at 16:19

rsvelko committed 2cbc7bc on 7.x-1.x

Issue #1978320 by aidanlis, rsvelko: Streamlined 7.x-2.x branch -...

Comment #7

rsvelko CreditAttribution: rsvelko commented 22 November 2014 at 16:20

committed this one also:
- 6 6899cfb Add a description for the username tracking

Comment #8

22 November 2014 at 17:09

rsvelko committed ec34e79 on 7.x-1.x

Issue #1978320 by aidanlis, rsvelko: Streamlined 7.x-2.x branch:  Tweak...

Comment #9

rsvelko CreditAttribution: rsvelko commented 17 December 2014 at 21:18

Summary of commits :

1 ec34e79 Issue #1978320 by aidanlis, rsvelko: Streamlined 7.x-2.x branch: Tweak the admin page to be less dependent on garland.
2 2cbc7bc Issue #1978320 by aidanlis, rsvelko: Streamlined 7.x-2.x branch - 6899cfb Add a description for the username tracking
3 8a28892 Issue #1978320 by aidanlis, rsvelko: Streamlined 7.x-2.x branch - Remove-unused-roles-query

The rest not used are just code rewrites to "unsuck" the code which need thorough testing and some parts could be commited after I find the time. Nothing functionally critical to the module functionality.

Comment #10

rsvelko CreditAttribution: rsvelko commented 22 November 2014 at 17:12

Priority:	Normal	» Minor
Status:	Needs review	» Postponed

Comment #11

rsvelko CreditAttribution: rsvelko commented 17 December 2014 at 21:19

So this could be postponed for long.... For now there is no real need for a whole new 2.x branch.

Comment #12

rsvelko CreditAttribution: rsvelko commented 21 February 2016 at 13:09

note: I used some code proposed here in the 1.x branch - see commit ec34e79

Comment #13

rsvelko CreditAttribution: rsvelko commented 28 February 2016 at 22:35

Assigned:	Unassigned	» rsvelko
Status:	Postponed	» Active

having a 2nd pass over the patch I could see some more code chunks that will be useful.
I will add things like the new async tracking code as an option and unsuck the code a bit more.

Comment #14

rsvelko CreditAttribution: rsvelko commented 25 March 2018 at 23:06

Status:

Active

» Fixed

in retrospective: although a proper 2.x branch never took off, ALL the worthy changes made in 7.x-2.x so far, were long ago backported to 1.x.
Closing this old issue now.