Do not translate $block->module assignments [#1978350]

Comment	File	Size	Author
#1	1978350-1-ctools-block_module_t.patch	7.22 KB	pfrenssen

Comment #1

pfrenssen

Sofia

CreditAttribution: pfrenssen commented 24 April 2013 at 06:44

Status:

Active

» Needs review

File	Size
1978350-1-ctools-block_module_t.patch	7.22 KB

Log in or register to post comments

Comment #1.0

pfrenssen

Sofia

CreditAttribution: pfrenssen commented 17 September 2013 at 08:37

Issue summary:

View changes

Clarified the problem.

Log in or register to post comments

Comment #2

2 January 2015 at 14:22

DamienMcKenna queued 1: 1978350-1-ctools-block_module_t.patch for re-testing.

Log in or register to post comments

Comment #3

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented 2 January 2019 at 03:41

Issue summary:

View changes

The 6 year old initial patch still applies cleanly to the latest ctools 7.x-1.x-dev, but still needs to be officially reviewed and tested by the community.

Applied patch plugins/content_types/node_form/node_form_attachments.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_author.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_book.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_buttons.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_comment.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_language.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_log.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_menu.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_path.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_publishing.inc cleanly.
Applied patch plugins/content_types/node_form/node_form_title.inc cleanly.

Log in or register to post comments

Comment #4

joelpittet

English

Vancouver

CreditAttribution: joelpittet at The University of British Columbia commented 4 January 2019 at 20:35

Status:

Needs review

» Fixed

Thanks for bringing this to my attention @Chris2, and for the patch @pfrenssen, I've committed this to the dev release.

Log in or register to post comments

Comment #5

4 January 2019 at 20:35

joelpittet committed dcd67cc on 7.x-1.x authored by pfrenssen

Issue #1978350 by pfrenssen, Chris2: Do not translate $block->module...

Log in or register to post comments

Comment #6

pfrenssen

Sofia

CreditAttribution: pfrenssen at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented 7 January 2019 at 10:47

Status:

Needs review

» Fixed

Thanks for following up on this!

Something went wrong with the issue status, @joelpittet has set it to Fixed but it still appears as Needs Review right now. Trying to set it back to Fixed.