For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

Meta issue: #1971384: [META] Convert page callbacks to controllers

Files: 
CommentFileSizeAuthor
#6 1978946-convert-page-callback-comment-edit1.patch1.64 KBtim-e
PASSED: [[SimpleTest]]: [MySQL] 55,550 pass(es).
[ View ]
#2 1978946-convert-page-callback-comment-edit.patch1.11 KBtim-e
PASSED: [[SimpleTest]]: [MySQL] 55,409 pass(es).
[ View ]

Comments

Assigned:Unassigned» tim-e

Status:Active» Needs review
StatusFileSize
new1.11 KB
PASSED: [[SimpleTest]]: [MySQL] 55,409 pass(es).
[ View ]

Patch attached.

+++ b/core/modules/comment/comment.routing.ymlundefined
@@ -0,0 +1,6 @@
\ No newline at end of file

needs a blank line

also comment_edit_page() function can go.

Status:Needs review» Needs work

Status:Needs work» Needs review
StatusFileSize
new1.64 KB
PASSED: [[SimpleTest]]: [MySQL] 55,550 pass(es).
[ View ]

Again

Issues with the title are part of the bigger issue in #1871596: Create a PartialResponse class to encapsulate html-level data [Moving to sandbox]
Wondering if we have tests for that... lets see what bot says first.

Status:Needs review» Reviewed & tested by the community

Yeah this is freaking awesome, #1913618: Convert EntityFormControllerInterface to extend FormInterface by tim.plunkett, amateescu makes it so simple.

Fixing tags

Status:Reviewed & tested by the community» Fixed

Committed 01b33f5 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.